ci: add GitHub Actions CI workflow#4
Conversation
![beta-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/2443040?s=60&v=4){kind=small}
| with: | ||
| python-version: "3.12" | ||
| - run: pip install pytest | ||
| - run: python -m pytest tests/ -v --tb=short 2>&1 || true |
There was a problem hiding this comment.
🔴 || true suppresses all test failures, making CI always pass
The pytest command ends with || true, which forces the step to exit with code 0 regardless of whether tests pass or fail. This completely defeats the purpose of a CI pipeline — broken code will never be caught. The || true should be removed so that test failures are properly reported.
| - run: python -m pytest tests/ -v --tb=short 2>&1 || true | |
| - run: python -m pytest tests/ -v --tb=short |
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
| - run: pip install pytest |
There was a problem hiding this comment.
🔴 CI installs only pytest but not the project's own dependencies
The workflow runs pip install pytest but never installs the project itself or its dependencies (e.g., pip install . or pip install -e .). Since the test file (test_conformance.py) imports conformance_core, and the project defines its build system in pyproject.toml, the tests may fail to import project modules unless they happen to work as raw scripts from the repo root. This is fragile and inconsistent with the project's pyproject.toml setup.
| - run: pip install pytest | |
| - run: pip install -e . |
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
SuperInstance
force-pushed
the
superz/add-ci
branch
from
67341b1 to
6dda0fe
Compare
|
Closing: superseded by merged work on main. The changes from this PR have been incorporated through other merged PRs. Thank you for the contribution! 🙏 |
1 participant
Adds CI workflow for automated testing on push and PR.