Skip to content

RCT-8354: Fix WCAG in guidelines block #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathevs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RCT-8354: Fix WCAG in guidelines block #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/dist/docs.min.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion exporter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"organization": "Supernova",
"source_dir": "src",
"assets_dir": "assets",
"version": "5.5.23",
"version": "5.5.24",
"usesBrands": false,
"config": {
"sources": "sources.json",
Expand Down
12 changes: 6 additions & 6 deletions scss/blocks/guidelines.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@

/* Guidelines: Colors */
--guidelinesDoInk: var(--colorGreen900);
--guidelinesDoInkSecondary: var(--colorGreen500);
--guidelinesDoBackground: var(--colorGreen100);
--guidelinesDoBorder: var(--colorGreen300);
--guidelinesDoBackgroundAlternative: var(--colorPositive);
Copy link
Contributor Author

@mathevs mathevs Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not even defined but used in styles

--guidelinesCautionInk: var(--colorOrange900);
--guidelinesCautionInkSecondary: var(--colorOrange500);
--guidelinesCautionBorder: var(--colorOrange300);
--guidelinesCautionBackground: var(--colorOrange100);
--guidelinesCautionBackgroundAlternative: var(--colorWarning);
--guidelinesDontInk: var(--colorRed900);
--guidelinesDontInkSecondary: var(--colorRed500);
--guidelinesDontBackground: var(--colorRed100);
--guidelinesDontBackgroundAlternative: var(--colorCritical);
--guidelinesDontBorder: var(--colorRed300);
}

Expand Down Expand Up @@ -137,7 +137,7 @@

&.guideline-item__type-caution {
.type-badge {
color: var(--guidelinesCautionInkSecondary);
color: var(--guidelinesCautionInk);
}

.type-badge__full {
Expand All @@ -148,7 +148,7 @@

&.guideline-item__type-dont {
.type-badge {
color: var(--guidelinesDontInkSecondary);
color: var(--guidelinesDontInk);
}

.type-badge__full {
Expand All @@ -159,7 +159,7 @@

&.guideline-item__type-do {
.type-badge {
color: var(--guidelinesDoInkSecondary);
color: var(--guidelinesDoInk);
}

.type-badge__full {
Expand Down
3 changes: 3 additions & 0 deletions scss/inc/theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
--colorOrange400: #f97316;
--colorOrange500: #e36b00;
--colorOrange900: #ba4e00;
--colorPositive: #118850;
--colorWarning: #CB4E13;
--colorCritical: #d23031;

/* Core tokens
/* =================================== */
Expand Down