update npm dependencies, and added a github action #20
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project's tooling and testing infrastructure by updating npm dependencies and migrating from Travis CI to GitHub Actions. The changes include migrating from CommonJS to ES modules, replacing ESLint/Prettier with Biome for code quality, and updating the TAP testing framework to the latest version.
Key changes:
- Migrated to ES modules with modern import/export syntax
- Replaced ESLint + Prettier with Biome for unified linting and formatting
- Added GitHub Actions CI pipeline replacing Travis CI
- Updated TAP test framework and modernized test structure
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependencies (tap ^21.1, biome ^0.3, codecov ^3.8), added "type": "module", and new npm scripts for linting/formatting |
| test/convert.test.js | Migrated from CommonJS to ES modules, wrapped tests in test() function following modern TAP pattern |
| biome.json | Added Biome configuration defining code style (4-space indent, double quotes, 120-char line width) |
| .github/workflows/ci.yml | New GitHub Actions workflow for CI with multi-version Node.js testing (18.x, 20.x, 22.x) and Codecov integration |
| README.md | Updated documentation with ES module usage examples, expanded testing instructions, and added development scripts |
| .gitignore | Simplified to only ignore .tap and node_modules directories |
| .travis.yml | Removed Travis CI configuration |
| .prettierrc | Removed Prettier configuration (replaced by Biome) |
| .eslintrc.json | Removed ESLint configuration (replaced by Biome) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:1
- The workflow uses
--writeflag in the lint step (line 32) which modifies files, then checks for formatting changes (lines 34-40). This creates a logical inconsistency: if files are auto-fixed by Biome, the check will always pass even when there were formatting issues. The lint step should run without--writeto verify code quality without modifications, or the formatting check should be removed since auto-fixing is applied.
name: CI
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.