Splitting SwiftLeeds & KotlinLeeds Build Configuration#93
Open
Splitting SwiftLeeds & KotlinLeeds Build Configuration#93
Conversation
PaulRWillis
approved these changes
Mar 28, 2026
| project: "SwiftLeeds.xcodeproj", | ||
| configuration: options[:configuration], | ||
| scheme: "SwiftLeeds", | ||
| scheme: options[:scheme] || "SwiftLeeds", |
Collaborator
There was a problem hiding this comment.
Does this default to SwiftLeeds if no scheme option is available?
| xcargs: "-skipPackagePluginValidation" | ||
| ) | ||
| lane :build_swiftleeds do | ||
| build(scheme: "SwiftLeeds", configuration: "Debug") |
Collaborator
There was a problem hiding this comment.
We're removing the xcargs: "-skipPackagePluginValidation" parameter here -- is it no longer needed?
|
|
||
| desc "Build KotlinLeeds scheme with Debug Configuration" | ||
| lane :build_kotlinleeds do | ||
| build(scheme: "KotlinLeeds", configuration: "Debug-KotlinLeeds") |
Collaborator
There was a problem hiding this comment.
As with here comment here, do we no longer need the xcargs parameter?
| 0B910A352A48FEC100648B32 /* SponsorTileView.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA57DE4E2875B09900911F03 /* SponsorTileView.swift */; }; | ||
| 0B910A372A49D07700648B32 /* Sponsor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0B910A362A49D07700648B32 /* Sponsor.swift */; }; | ||
| 0B910A382A49D09300648B32 /* Sponsor.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0B910A362A49D07700648B32 /* Sponsor.swift */; }; | ||
| 13707030C1082B933C28151D /* SwiftLeedsAssets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 4301D0D3F1C8979276E77084 /* SwiftLeedsAssets.xcassets */; }; |
Collaborator
There was a problem hiding this comment.
Just to note, we'll eventually be deleting these asset files for both apps once we migrate to the new versions in Sources/SharedAssets
That should help with avoiding having to mess with .pbxproj files 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConferenceConfigreads conference-specific values (API host, contact email, app group) fromInfo.plist, replaces (most of them anyways) hardcodedswiftleeds.co.uk/ SwiftLeeds references in the codebaseSwiftLeedsAssets/KotlinLeedsAssetsandSwiftLeedsColors/KotlinLeedsColorsasset catalogs for main app, Widget, and AppClip, swapped viaEXCLUDED_SOURCE_FILE_NAMES(hence the huge changes and all the images/assets in this PR)KotlinLeedsXcode scheme withDebug-KotlinLeeds/Release-KotlinLeedsbuild configurations across all targetsEXCLUDED_SOURCE_FILE_NAMES- swaps asset catalogs per conference. Any new asset catalog withSwiftLeedsorKotlinLeedsin the name will be excluded from the opposite schemeConcerns
kotlinleeds.co.ukassociated domains andgroup.uk.co.kotlinleedsapp group. Need matching App ID configuration in the Apple Developer portal before signing works on real devicesuk.co.kotlinleeds.*bundle IDs. No provisioning profiles or App Store Connect entries exist yet