fix: check font.family of current iteration with current family#68
Open
mangkoran wants to merge 1 commit intoSwirt:masterfrom
Open
fix: check font.family of current iteration with current family#68mangkoran wants to merge 1 commit intoSwirt:masterfrom
mangkoran wants to merge 1 commit intoSwirt:masterfrom
Conversation
Author
|
Friendly mention @Swirt :D |
Author
|
Cc @Swirt sorry to bump this PR, but is there anything that should be done before this PR could be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for developing such amazing tool. I just started to learn about scanlating yesterday and found TyperTools very helpful. I hope this tools could help many for generations to come.
This PR should address #56 where the font family will unexpectedly change if we would like to change font style. This is due to the logic currently used only check for
font.stylewhich will make the first font that have the selected style will be chosen instead of the correct one. This PR adds a checkfont.family === family.Current master
This PR
Tested on
Fix #56