add seasonality with monthly values to example scenario #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-s-code
approved these changes
Jan 22, 2026
Collaborator
b-s-code
left a comment
b-s-code
left a comment
There was a problem hiding this comment.
I support the inclusion of example monthly values.
The monthly values added here give different output to what is obtained by specifying Fourier coefficients.
The difference isn't huge and I assume it is to be expected? E.g. these output plots look similar but there are some observable differences. Top row = Fourier coefficients in XML, bottom row = monthly values in XML.
I don't suppose there's any reason this might be an issue? None come to my mind.
If no concerns on your end then I'm happy for this to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example scenario uses Fourier coefficients for seasonality. In practice, users may prefer monthly values. This PR adds an example using monthly values.