-
Notifications
You must be signed in to change notification settings - Fork 102
FEATURE: Dockerfile for consistent builds #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Dockerfile for consistent builds #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Sameersawant77 for your contribution. This is looking good to me. I have add a small comment on the script. But, also, can you also add a section to the readme about how to use the docker image?
Finally, I have tried it on Ubuntu machine, which machines have you tried it on? mac? windows?
Dockerfile
Outdated
| RUN echo 'alias jpf-build="cd /app/jpf-core && ./gradlew build -x test && cd /app/jpf-symbc && ./gradlew build -x test"' >> /root/.bashrc | ||
| RUN echo 'alias jpf-run="java -Xmx1024m -ea -Djava.library.path=/app/jpf-symbc/lib -jar /app/jpf-core/build/RunJPF.jar"' >> /root/.bashrc | ||
| RUN echo 'alias jpf-sv="bash /app/jpf-symbc/bin/jpf-sv-comp.sh"' >> /root/.bashrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change the alias names to have the prefix "spf" instead of "jpf"
Dockerfile
Outdated
| RUN echo 'alias jpf-run="java -Xmx1024m -ea -Djava.library.path=/app/jpf-symbc/lib -jar /app/jpf-core/build/RunJPF.jar"' >> /root/.bashrc | ||
| RUN echo 'alias jpf-sv="bash /app/jpf-symbc/bin/jpf-sv-comp.sh"' >> /root/.bashrc | ||
|
|
||
| RUN chmod +x /app/jpf-symbc/bin/jpf-sv-comp.sh && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment about usage of dos2unix here
|
Thank you for the review @sohah. I made the changes as commented. I also updated the Readme.md file for steps to build with Docker. As for your question about machine, I am testing it using a Macbook, although it should ideally work perfectly with Windows too |
|
Just now, added few commits. Making the docker file minimalistic and building inside the docker interactive mode. As i was having build issues using the build alias because SPF requires sequential build i.e First building jpf-core and then building jpf-symbc. Attaching my build steps for reference: |
|
Also i got caught up with solving the docker build issues today, I will look into cast1.yml issue as suggested by you |
|
@Sameersawant77 , thank you for contribution. This looks better for development. @yannicnoller , can we please have this PR accepted? Thank you! |
Fixes #138
Added Dockerfile for Consistent and Streamlined setup to resolve OS and dependencies issues.