Skip to content

permission exception bug #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjmyers merged 4 commits into from
Nov 14, 2025
Merged

permission exception bug #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60105e5
this should get rid of the endpoints that limit the permission except…
Kenzo-Schwab Oct 31, 2025
64b2329
it now works with the create collections erorr
Kenzo-Schwab Nov 5, 2025
93ef85d
now, error messages are automatically opened to show their body
Kenzo-Schwab Nov 13, 2025
be94731
and now the login button is visible after you close out the error mes…
Kenzo-Schwab Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SBOLCanvasFrontend/src/app/error/error.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<h1 mat-dialog-title>An error has occurred.</h1>
<mat-expansion-panel>
<mat-expansion-panel [expanded]="true">
<mat-expansion-panel-header>

<mat-panel-description>
Click to view more details.
Click to see less Details.
</mat-panel-description>
</mat-expansion-panel-header>

Expand Down
26 changes: 17 additions & 9 deletions SBOLCanvasFrontend/src/app/http.interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { Observable, of, throwError } from "rxjs";
import { tap, catchError } from "rxjs/operators";
import { MatDialog } from '@angular/material/dialog';
import { ErrorComponent } from './error/error.component';
import { UploadGraphComponent } from './upload-graph/upload-graph.component';
import { CollectionCreationComponent } from './collection-creation/collection-creation.component';
import { ActivatedRoute } from '@angular/router'
import { LoginService } from './login.service';

Expand Down Expand Up @@ -31,15 +33,9 @@ intercept(
if(err instanceof HttpErrorResponse && err.status === 500) {
!this.ignoreHTTPErrors && this.dialog.open(ErrorComponent, {data: err.error});
}
if (err instanceof HttpErrorResponse && err.status === 401) {
if (err instanceof HttpErrorResponse) {
const url = req.url || '';
const isTargetEndpoint = (
url.includes('/SynBioHub/logout') ||
url.includes('/SynBioHub/listRegistryParts') ||
url.includes('/SynBioHub/listMyCollections')
);

if (isTargetEndpoint) {
const body = err.error;
const permissionMarker = 'org.synbiohub.frontend.PermissionException';
const isPermissionException = typeof body === 'string' && body.indexOf(permissionMarker) >= 0;
Expand All @@ -50,9 +46,21 @@ intercept(

const serverLabel = serverParam || 'the registry';
const message = `Disconnected from ${serverLabel}. Please sign in again.`;
!this.ignoreHTTPErrors && this.dialog.open(ErrorComponent, { data: message });
try {
this.dialog.openDialogs.forEach(d => {
try {
const ci = d.componentInstance;
if (ci instanceof CollectionCreationComponent) {
d.close();
}
} catch(e) {
}
});
} catch(e) {
}

!this.ignoreHTTPErrors && this.dialog.open(ErrorComponent, { data: message });
}
}
}
return throwError(err);
}));
Expand Down