-
Notifications
You must be signed in to change notification settings - Fork 53
feat(ledger): sig->agave ledger migration tool #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3668451 to
41ce8c5
Compare
41ce8c5 to
e5c0b80
Compare
InKryption
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some basic naming nits, otherwise lgtm.
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Co-authored-by: Drew Nutter <dnut@users.noreply.github.com>
|
|
||
| const cmd_info: cli.CommandInfo(@This()) = .{ | ||
| .help = .{ | ||
| .short = "Convert a between Sig and Agave ledger formats", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .short = "Convert a between Sig and Agave ledger formats", | |
| .short = "Convert between Sig and Agave ledger formats", |
| .help = .{ | ||
| .short = "Convert a between Sig and Agave ledger formats", | ||
| .long = | ||
| \\Migrates to and from Sig's and Agave's RocksDb ledger formats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the full instruction list here as specified in the PR description? I would like to avoid any users getting confused if attempting to use the ledger tool directly before running Agave validator which fixes up the ledger after conversion
This is for when you have a ledger from Sig, but want to cross-validate with Agave (or vice versa).
This tool will take in your Sig ledger directory, and a (new) agave ledger directory, and port the data over.
Usage:
sig agave-migration-tool -i sig-ledger-dir -o agave-ledger-dir