Open
Conversation
hgrano
suggested changes
Dec 11, 2023
| EXPOSE 8090 | ||
|
|
||
| CMD ["sh","-c","npm start"] | ||
| CMD ["sh", "-c", "npm run build && serve -s build -l 8090"] |
Contributor
There was a problem hiding this comment.
Can we move the npm run build part outside of the CMD section? The build output should be created once during the creation of the image, that way when we deploy the container we do not have to build it again. The build might fail at run time as we have not yet tested it until then. Also, the output of npm run build could change at run time as new versions of the dependencies are released and it downloads these newer versions
Contributor
Author
There was a problem hiding this comment.
After reading the documentation I saw that after building a react app all code is static and can't be changed.
Here is the documentation:
https://create-react-app.dev/docs/adding-custom-environment-variables/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change represents a minor enhancement, leveraging the minified version generated by 'npm run build' using the external .env file.