[#943][feat] Add standalone lol rebase command and fix FSM rebase-to-review transition#961
Open
ayazhankadessova wants to merge 4 commits intomainfrom
Open
[#943][feat] Add standalone lol rebase command and fix FSM rebase-to-review transition#961ayazhankadessova wants to merge 4 commits intomainfrom
ayazhankadessova wants to merge 4 commits intomainfrom
Conversation
…issue #943. - python/agentize/workflow/impl/impl.md: Update Mermaid diagram to show rebase→review instead of rebase→impl. - python/agentize/workflow/impl/transition.md: Update transition coverage from rebase→impl/fatal to rebase→review/fatal. - python/agentize/workflow/impl/kernels.md: Document review counter reset behavior in rebase_stage_kernel on EVENT_REBASE_OK. - src/cli/lol/commands/README.md: Add rebase.sh / _lol_cmd_rebase to file map table.
. - python/agentize/workflow/impl/transition.py: Change (STAGE_REBASE, EVENT_REBASE_OK) target from STAGE_IMPL to STAGE_REVIEW. - python/agentize/workflow/impl/kernels.py: Reset review_fail_streak, review_attempts, and last_review_score on EVENT_REBASE_OK in rebase_stage_kernel. - python/tests/test_impl_fsm.py: Add rebase→review transition assertion, review counter reset test, and rebase→review→simp→pr→finish orchestrator test. All 39 tests pass.
…sue #943. - python/agentize/cli.py: Add `handle_rebase()` with auto-detect main/master, fetch, rebase, and conflict abort. Add `rebase` subparser with `--target-branch`. - src/cli/lol/commands/rebase.sh: New `_lol_cmd_rebase` delegating to Python CLI. - src/cli/lol/parsers.sh: Add `_lol_parse_rebase` with `--target-branch` flag. - src/cli/lol/dispatch.sh: Add `rebase)` case and help text entry. - src/cli/lol/commands.sh: Source `commands/rebase.sh`. - src/cli/lol/completion.sh: Add `rebase` command and `rebase-flags` completion. All 39 tests pass.
… for issue #943. - src/cli/lol/commands/rebase.sh: Use conditional branching instead of string concatenation to avoid word-splitting/zsh incompatibility. - python/agentize/cli.py: Replace getattr() with direct args.target_branch access for consistency with other handlers. - python/agentize/cli.md: Add `rebase` and `plan` commands to Commands table. All 39 FSM tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(STAGE_REBASE, EVENT_REBASE_OK)now routes toSTAGE_REVIEWinstead ofSTAGE_IMPL, ensuring code is re-reviewed after rebasereview_fail_streak,review_attempts,last_review_score) inrebase_stage_kernel()on successful rebaselol rebase [--target-branch <branch>]CLI command with auto-detect main/master, fetch, rebase, and conflict abortTest plan
PYTHONPATH=python python -m pytest python/tests/test_impl_fsm.py— 39/39 passTEST_SHELLS="bash zsh" make test-fast— 407/407 passPYTHONPATH=python python -m agentize.cli rebase --help— outputs correct help_lol_complete commandsincludesrebase,_lol_complete rebase-flagsreturns--target-branchCloses #943