Conversation
Implement equal-width tabs for the VSCode plugin's unified view to improve visual harmony and professional appearance. Changes: - vscode/src/view/unifiedViewProvider.ts: - Add `flex: 1` to distribute equal width to all three tabs (Plan, Worktree, Settings) - Add `text-align: center` to center tab labels - Add `white-space: nowrap` to prevent text wrapping - Add `overflow: hidden` and `text-overflow: ellipsis` for graceful overflow handling - vscode/src/view/unifiedViewProvider.md: - Document tab styling behavior including flexbox equal-width distribution - Document overflow protection strategy for narrow sidebars - tests/vscode/test-tab-styling.sh: - New visual regression test to verify all required CSS properties are present - Tests verify properties exist within correct CSS block context All tests pass: - tests/vscode/test-link-detection.sh: 14 passed, 0 failed - tests/vscode/test-step-progress-parser.sh: 7 passed, 0 failed - tests/vscode/test-tab-styling.sh: passed Build verified: `make vscode-plugin` compiles successfully with no errors. closes #963
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[feat][#963] VSCode Plugin Equal-Width Tabs with Overflow Protection
Implement equal-width tabs for the VSCode plugin's unified view to improve
visual harmony and professional appearance.
Changes
vscode/src/view/unifiedViewProvider.ts:
flex: 1to distribute equal width to all three tabs (Plan, Worktree, Settings)text-align: centerto center tab labelswhite-space: nowrapto prevent text wrappingoverflow: hiddenandtext-overflow: ellipsisfor graceful overflow handlingvscode/src/view/unifiedViewProvider.md:
tests/vscode/test-tab-styling.sh:
Success Criteria
flex: 1distributes equal width to all three tabstext-align: centercenters tab labelswhite-space: nowrapprevents text wrappingtext-overflow: ellipsistruncates with "..." when space is insufficientTest Results
Build verified:
make vscode-plugincompiles successfully with no errors.Issue 963 resolved
closes #963