Conversation
Allow VS Code plan/implementation logs to linkify GitHub PR URLs the same way as issue URLs,
while keeping external URL opening restricted to canonical GitHub issue/PR routes.
File changes:
- `vscode/webview/plan/utils.ts`
- Expanded log link detection from issue-only to issue+PR routes.
- Tightened matching to canonical route boundaries so extra path/query/fragment segments are not linkified.
- `vscode/src/view/unifiedViewProvider.ts`
- Expanded URL allowlist from issue-only to issue+PR canonical routes.
- Added `openExternalGitHubUrl()` as the single allowlist gate and reused it in:
- `plan/view-issue`
- `plan/view-pr`
- `link/openExternal`
- `tests/vscode/test-link-detection.sh`
- Updated regex fixtures to match issue+PR canonical behavior.
- Added PR-positive detection coverage.
- Added allowlist validation coverage for canonical positives and unsupported-route negatives.
- `vscode/webview/plan/utils.md`
- Documented canonical issue+PR linkification contract for `renderLinks()`.
- `vscode/src/view/unifiedViewProvider.md`
- Documented canonical issue+PR URL validation and shared external-open gate.
- `docs/workflows/vscode-extension.md`
- Documented inline issue/PR linkification and canonical external-open restrictions.
- `docs/tutorial/03-vscode-planning.md`
- Documented clickable canonical issue/PR links in logs.
Related issue:
- #965
Tests:
- `make vscode-plugin`: PASS
- `tests/vscode/test-link-detection.sh`: PASS (20 passed, 0 failed)
- `TEST_SHELLS="bash zsh" make test-fast`: PASS
- Bash suite: 58 passed, 0 failed
- Zsh suite: 58 passed, 0 failed
- Python suite: 405 passed, 0 failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[bugfix][#965] Render canonical GitHub PR links in VS Code logs
Summary
This PR fixes VS Code plan/implementation log link handling so canonical GitHub pull request URLs are treated the same as canonical issue URLs.
What Changed
plan/view-issue,plan/view-pr, andlink/openExternal.Validation
make vscode-pluginpassed.tests/vscode/test-link-detection.shpassed (20 passed, 0 failed).TEST_SHELLS="bash zsh" make test-fastpassed:Issue 965 resolved
closes #965