Skip to content

Fix reloadData bug causing no refresh when content changes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psilvis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix reloadData bug causing no refresh when content changes #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion SYPaginator/SYPaginatorView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ @implementation SYPaginatorView {
NSMutableDictionary *_reuseablePages;
BOOL _pageControlUsed;
BOOL _pageSetViaPublicMethod;
BOOL _pageContentNeedsRefresh;
}

@synthesize scrollView = _scrollView;
Expand Down Expand Up @@ -155,6 +156,7 @@ - (void)willMoveToSuperview:(UIView *)newSuperview {
#pragma mark - Managing data

- (void)reloadData {
_pageContentNeedsRefresh = YES;
[self reloadDataRemovingCurrentPage:YES];
}

Expand Down Expand Up @@ -402,7 +404,7 @@ - (void)_reusePages {


- (void)_setCurrentPageIndex:(NSInteger)targetPage animated:(BOOL)animated scroll:(BOOL)scroll forcePreload:(BOOL)forcePreload {
if (_currentPageIndex == targetPage && _pageSetViaPublicMethod != YES) {
if (_currentPageIndex == targetPage && _pageSetViaPublicMethod != YES && _pageContentNeedsRefresh != YES) {
return;
}

Expand Down Expand Up @@ -449,6 +451,7 @@ - (void)_setCurrentPageIndex:(NSInteger)targetPage animated:(BOOL)animated scrol
}

_pageSetViaPublicMethod = NO;
_pageContentNeedsRefresh = NO;
}


Expand Down