Skip to content

Conversation

apitamy
Copy link

@apitamy apitamy commented Jun 20, 2024

Small change to bypass errors with self signed certificates.

@Szwendacz99
Copy link
Owner

Ignoring TLS certificates validation is generally not recommended, but can have use in some scenarios, like testing. Therefore I can allow it, but it should not be default. I would say the best approach is to add another boolean parameter to the parser (other boolean parameters are --dont-export-attachments, --force-update-files, etc..), that will enable those lines:

ctx.check_hostname = False
ctx.verify_mode = ssl.CERT_NONE

only if someone intentionally add that parameter.

@apitamy
Copy link
Author

apitamy commented Jun 21, 2024

makes total sense. I'll work on that but it may take a bit. Thanks for input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants