Skip to content

Conversation

@Leadballoon2000
Copy link

No description provided.

@Leadballoon2000
Copy link
Author

cmangos/issues#999

@killerwife
Copy link

Dude, rename the commit, put that into commit message :D

@Leadballoon2000 Leadballoon2000 changed the title Ported from TrinityCore 'Thanks to nelegalno and gecko32' Quest gossip added for 10722, also mob abilities Jul 10, 2016
@killerwife
Copy link

  1. did you unify the ids with UDB
  2. you renamed PR and not commit :D

@Grz3s
Copy link

Grz3s commented Jul 11, 2016

Gossip Id's - are coming from sniff... and always must be the same (no diff if its UDB , TBC-DB, trinity etc...) we cannot change them
Conditions will be different for each Database... (first free need to be used;) )

@killerwife
Copy link

I have a rule atm that we try to use UDB condition ids whenever possible when backporting, to mitigate the mess among versions. :P (for new ones, i use the rule you mentioned)

Ported from TrinityCore 'Thanks to nelegalno and gecko32'
@Leadballoon2000
Copy link
Author

OK, I've reconciled the condition IDs with UDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants