[#13365] Add validation for email input in feedback form #13387
+711
−308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re proper input format.
…es, and valid ones show green confirmation hints. Updated the form logic to prevent submission of invalid email addresses and removed temporary test inputs.
|
Hi @Shuhui-Yang525, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
|
I'm a group member and I tested this function. |
|
Good work but needs minor adjustments for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13365
Implemented client-side validation for email-type questions in feedback sessions.
Now, when a question in a feedback session expects an email address, the input field validates the format before submission. Users will only be able to submit the form if the entered value is a valid email.
Additionally:
Added corresponding error message styling: invalid email inputs are highlighted in red.
Updated relevant CSS classes to ensure error state is clear and consistent with the existing UI styling.
Tested to confirm correct behavior:
Valid email format → form submits normally.
Screenshots are included below to demonstrate the UI changes
Before:
After:
