-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[#13320] Refactoring data deletion logic to enhance maintainability and debugging #13389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rainboh0622
wants to merge
26
commits into
TEAMMATES:master
Choose a base branch
from
rainboh0622:refactoring-data-deletion-logic-to-enhance-maintainability-and-debugging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,995
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored deletion for Logic.java, CoursesLogic.java, InstructorsLogic.java, StudentsLogic.java. Problem: DeletionService.initLogicDependencies not run. Tests will fail.
Refactored deletion for AccountsLogic.java, AccountRequestsLogic.java Problem: DeletionService.initLogicDependencies not run. Tests will fail.
|
Hi @rainboh0622, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
|
Update PR title to start with [#13320] (add a space between it and the rest of title?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13320
**Outline of Solution
Modified Classes:
Added deletedAt Instant and relevant methods into:
Linked deletedAt Instants between corresponding entity/atttribute classes by editing valueOf().