[#12596] Instructor extending individual deadlines: table doesn't sort by team #13394
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validation and visual feedback for Course ID and Course Name fields in the Copy Course modal to ensure consistency with the Create Course page. Empty fields now display red warning text and an exclamation icon when left blank. This change aligns the Copy Course form behavior with the Create Course form and addresses issue TEAMMATES#12653.
…TEAMMATES#12679) fix: prevent whitespace-only input in copy-session-modal (TEAMMATES#12679)
…y-fields-not-highlighted Fix: highlight mandatory fields in Copy Course modal (TEAMMATES#12653)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12596
Outline of Solution
Summary
Fix Team-column sorting on the Instructor → Individual Deadline Extensions page. The comparator was correct, but the component passed the wrong field for SortBy.TEAM_NAME (used sectionName instead of teamName). Replaced field references so sorting now groups and orders rows by actual team names.
Fix (what changed)
In sortStudentPanelsBy(...), update the TEAM_NAME branch to use a.teamName / b.teamName.
No API/schema changes; frontend-only, minimal diff.
Files touched
src/web/app/pages-instructor/instructor-session-individual-extension-page/instructor-session-individual-extension-page.component.ts
case SortBy.TEAM_NAME: → teamName (was sectionName)
(tests) src/web/app/pages-instructor/instructor-session-individual-extension-page/instructor-session-individual-extension-page.component.spec.ts
Adds regression spec: first click = ASC (Team 1 → Team 2 → Team 3), second click = DESC (reverse).
Control: Name column ASC still works.