[#13304] Refactoring for Unit Test Access Controls #13400
+10
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 22, 2025 21:38
…onTest.java access control methods
…nTest.java access control methods
…ActionTest.java access control method
Contributor
|
@MCcoc01 thanks for your contributions. Your contribution looks almost complete and good to go. However, the errors for GitHub Action should have only failed for E2E tests, as that is a separate issue, which should be merged soon. Please fix the related issues, tag me afterwards, and I'll review your PR after all related failures have passed Thanks and happy coding! |
Author
|
@InfinityTwo thanks for your time. I fixed the issue, it should be fine now. |
Contributor
|
@MCcoc01 thanks for the styling fixes. I'll mark yours ready for review for when the unrelated failing tests passes. However, I think E2E Tests (not the sql one) should not fail, but the E2E Sql should fail. Could you also fix this issue in the meantime? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13304
Outline of Solution
The code refactors the unit test access controls for methods in sqlui/webapi.
The refactored files are: