Ensure deterministic ordering in DB queries to prevent flaky tests #13416
+90
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: [#13415] Non-deterministic ordering in DB queries causes inconsistent API behavior and flaky tests
Fixes #13415
Outline of Solution
Enforce deterministic ordering on collection queries in the SQL layer
(UsersDb, AccountRequestsDb, NotificationsDb, FeedbackSessionsDb, AccountsDb)
using explicit
ORDER BY.Enforce deterministic ordering on Objectify/Datastore queries
(StudentsDb, InstructorsDb, FeedbackSessionsDb, AccountsDb)
via
.order(...).Remove redundant in-memory sorting in
UsersLogicnow that DB queries returnordered results.