Print pending tasks

[devreal]

Also fixes a case in the Dot printer where we print a type even if we were asked not to.

[Copilot]

Pull request overview

This PR introduces a new debugging hook to print “incomplete/pending” tasks from TTG operations, plumbing it through composite TTGs and implementing it for the PaRSEC backend, plus a small tweak to DOT graph labeling when types are disabled.

Changes:

• Add TTBase::print_incomplete_tasks() virtual API and forward it from TTG.
• Implement print_incomplete_tasks() for ttg_parsec::TT by iterating the PaRSEC task hash table.
• Adjust DOT label output when disable_type is enabled.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
ttg/ttg/util/dot.h	Tweaks DOT record-label formatting when type display is disabled.
ttg/ttg/tt.h	Adds TTG-level forwarding implementation of print_incomplete_tasks().
ttg/ttg/parsec/ttg.h	Implements print_incomplete_tasks() for PaRSEC TT by iterating tasks_table.
ttg/ttg/base/tt.h	Adds the new print_incomplete_tasks() virtual method to the TTBase API.

Comments suppressed due to low confidence (1)

ttg/ttg/util/dot.h:105

• Output terminal names are inserted into the DOT record label without escaping. If an output name contains <, >, ", or |, it can break DOT parsing; use the existing escape() helper for output names (in both the disable_type and typed branches).

            if (disable_type) {
              ttss << " <out" << count << ">"
                   << out->get_name();
            } else {
              ttss << " <out" << count << ">"
                   << " " << escape("<" + out->get_key_type_str() + "," + out->get_value_type_str() + ">") << " "
                   << out->get_name();
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

TTBase::print_incomplete_tasks() throws std::runtime_error but this header does not include <stdexcept>, which will fail to compile in translation units that don’t get it transitively. Add the missing include (or move the definition to a header that already includes it).

[Copilot]

Default-implementing print_incomplete_tasks() by throwing makes the new API hazardous to call on runtimes that don’t override it (and TTG::print_incomplete_tasks() will propagate those throws across mixed graphs). Consider making the base implementation a no-op (or making it pure virtual if all runtimes must support it) so this debug helper can be safely invoked generically.

Suggested change

	virtual void print_incomplete_tasks() const {
	throw std::runtime_error("print_incomplete_tasks not implemented!");
	}
	/// Debug hook: default implementation is a no-op so it is safe to call generically.
	virtual void print_incomplete_tasks() const {}

[Copilot]

When disable_type is true, the record label concatenates the port (<inN>) and the terminal name without any separator. This makes the DOT output harder to read and can be fragile for Graphviz record labels; consider keeping a leading space before the escaped name for consistency with the typed branch.

[Copilot]

print_incomplete_tasks() is now const but uses C-style casts to drop constness for both tasks_table and this. Prefer const_cast (or make tasks_table mutable if iteration is logically-const) and pass a const ttT* through cb_data so ht_iter_cb doesn’t need to cast away const.

[Copilot]

This forwards print_incomplete_tasks() to all contained ops; with the current TTBase default implementation throwing, this TTG-level call will throw as soon as it encounters a child TT that doesn’t override the method. If the intent is a best-effort debug print, consider making the base implementation a no-op or handling the unsupported case here to avoid aborting the whole traversal.

Suggested change

	for (auto& tt : tts) {
	tt->print_incomplete_tasks();
	for (auto &tt : tts) {
	try {
	tt->print_incomplete_tasks();
	} catch (...) {
	// Ignore unsupported or failing implementations to avoid aborting traversal
	}