develp branch 작업내용 머지 : develop -> main #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8ca08c9.
[FIX] 9월 3주차 QA 사항 - 희용
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. Walkthrough인증 토큰 흐름에 preAuthToken/isNewUser를 도입하고, 요청 인터셉터 로직을 갱신했습니다. 알림 목록 API/페이지를 신설하여 페이징 로딩을 구현했습니다. 회원 탈퇴 API를 추가하고 마이페이지 탈퇴 플로우에 연동했습니다. 그룹 카드/모달 UI 조건 로직을 조정하고, 피드/그룹 헤더에 공지 이동을 추가했습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant App
participant API as apiClient (interceptor)
participant Svr as Server
User->>App: 네비게이션/액션으로 API 호출
App->>API: request(config)
alt authToken 존재
API->>Svr: Authorization: Bearer authToken
else signup 경로 AND preAuthToken 존재
API->>Svr: Authorization: Bearer preAuthToken
else 공개 경로
API->>Svr: (헤더 없음)
else 비공개 경로 AND 토큰 없음
API-->>App: 요청 취소(redirect to /)
App->>User: 홈으로 이동
end
Svr-->>API: response / 401
alt 401
API->>App: 401 처리(홈 리다이렉트)
else 성공
API-->>App: response.data
end
sequenceDiagram
autonumber
actor User as 신규 소셜 로그인 사용자
participant App
participant Auth as getToken
Note over App,Auth: 콜백으로 토큰 교환
App->>Auth: GET /auth/token
Auth-->>App: { token, isNewUser: true }
App->>App: preAuthToken 저장, authToken 제거
App->>User: 회원가입 플로우로 진행
User->>App: 회원가입 완료
App->>App: authToken 저장, preAuthToken 제거
sequenceDiagram
autonumber
actor User
participant Notice as Notice Page
participant API as getNotifications
User->>Notice: 스크롤/탭 전환
Notice->>API: /notifications?cursor=...&type=feed|room
API-->>Notice: { notifications, nextCursor, isLast }
alt isLast=false
Notice->>User: 다음 페이지 준비
else
Notice->>User: 더 이상 없음
end
sequenceDiagram
autonumber
actor User
participant Page as WithdrawPage
participant API as deleteUsers
User->>Page: 탈퇴 확인
Page->>API: DELETE /users
alt 성공
API-->>Page: { isSuccess: true, data: null }
Page->>Page: 토큰 정리
Page->>User: 완료 페이지로 이동
else 실패
API-->>Page: 에러/메시지
Page->>User: 스낵바로 오류 안내
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이하동일
Summary by CodeRabbit