Open
Conversation
+ Comment claims no support for partitions, but `dev->num_partition_properties = 1` implies `dev->partition_properties` should be populated. This causes a segfault when running `clinfo`, which tries to read one element from `partition_properties`. Fix by setting `num_partition_properties = 0` to align with comment, and adjust `dev->max_sub_devices` to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev->num_partition_properties = 1impliesdev->partition_propertiesshould be populated. This causes a segfault when runningclinfo, which tries to read one element frompartition_properties. Fix by settingnum_partition_properties = 0to align with comment, and adjustdev->max_sub_devicesto match.