Skip to content

build: auto-detect NVIDIA driver, skip sbtsim/PTX when unavailable#11

Merged
Humber-186 merged 5 commits intodevelopfrom
copilot/add-nvidia-driver-check
Apr 22, 2026
Merged

build: auto-detect NVIDIA driver, skip sbtsim/PTX when unavailable#11
Humber-186 merged 5 commits intodevelopfrom
copilot/add-nvidia-driver-check

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 21, 2026

  • 修改 else 分支:既不给 --matrix 也不给 --checklist 时,不再强制走 rtl-both,改为单模式继承 VENTUS_BACKEND 环境变量,checklist 默认 all
  • 同步更新相关注释和 --matrix help 文字

…lt rtl-both matrix override

Agent-Logs-Url: https://github.com/THU-DSP-LAB/ventus-env/sessions/8f996d6b-f63e-48f4-b3eb-c46aa6f3fc40

Co-authored-by: Humber-186 <76775111+Humber-186@users.noreply.github.com>
@Humber-186 Humber-186 marked this pull request as ready for review April 22, 2026 02:37
Copilot AI review requested due to automatic review settings April 22, 2026 02:37
@Humber-186 Humber-186 merged commit 3e423ff into develop Apr 22, 2026
2 of 4 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the build and regression-test tooling to better adapt to the execution environment (NVIDIA driver presence) and to make regression-test.py’s default behavior align with VENTUS_BACKEND when neither --matrix nor --checklist is provided.

Changes:

  • regression-test.py: Change default behavior (no --matrix / no --checklist) from the rtl-both matrix preset to single-mode inheriting VENTUS_BACKEND, with checklist defaulting to all; update related help text/comments.
  • build-ventus.sh: Auto-detect NVIDIA driver availability; skip sbtsim build and disable driver PTX support when unavailable.
  • CI workflow: Update regression-test invocations to explicitly pass checklists and adjust timeout scales for slower backends.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
regression-test.py Adjusts default CLI behavior to single-mode (inherits VENTUS_BACKEND) and updates --matrix help/commentary accordingly.
build-ventus.sh Adds NVIDIA driver detection and conditionally skips sbtsim / disables PTX in driver builds when unavailable.
.github/workflows/every.yml Updates CI regression-test commands to match the new default semantics and tunes timeouts/checklists per backend.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build-ventus.sh
Comment on lines +93 to +97
if [ "${NVIDIA_DRIVER_AVAILABLE}" = "false" ]; then
echo "WARNING:*************************************************************"
echo
echo "NVIDIA driver not found. Skipping sbtsim (SBT PTX translator) build."
echo "If you need sbtsim, please install the NVIDIA driver and try again."
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NVIDIA-driver check runs at script startup and emits this "Skipping sbtsim" warning whenever no driver is detected, even if the current invocation isn’t building sbtsim/ptx targets (e.g. --build llvm). Consider only printing this warning when sbtsim/ptx (or driver PTX support) is actually requested/needed based on PROGRAMS_TOBUILD.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants