build: auto-detect NVIDIA driver, skip sbtsim/PTX when unavailable#11
build: auto-detect NVIDIA driver, skip sbtsim/PTX when unavailable#11Humber-186 merged 5 commits intodevelopfrom
Conversation
… unavailable Agent-Logs-Url: https://github.com/THU-DSP-LAB/ventus-env/sessions/14a9defb-f7a8-4169-a381-257278c63bf3 Co-authored-by: Humber-186 <76775111+Humber-186@users.noreply.github.com>
Agent-Logs-Url: https://github.com/THU-DSP-LAB/ventus-env/sessions/14a9defb-f7a8-4169-a381-257278c63bf3 Co-authored-by: Humber-186 <76775111+Humber-186@users.noreply.github.com>
Agent-Logs-Url: https://github.com/THU-DSP-LAB/ventus-env/sessions/c16f9534-9ac6-4c0c-aac3-553483d945bc Co-authored-by: Humber-186 <76775111+Humber-186@users.noreply.github.com>
…lt rtl-both matrix override Agent-Logs-Url: https://github.com/THU-DSP-LAB/ventus-env/sessions/8f996d6b-f63e-48f4-b3eb-c46aa6f3fc40 Co-authored-by: Humber-186 <76775111+Humber-186@users.noreply.github.com>
Agent-Logs-Url: https://github.com/THU-DSP-LAB/ventus-env/sessions/2c29b99f-47eb-4bf5-b913-3135df562544 Co-authored-by: Humber-186 <76775111+Humber-186@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the build and regression-test tooling to better adapt to the execution environment (NVIDIA driver presence) and to make regression-test.py’s default behavior align with VENTUS_BACKEND when neither --matrix nor --checklist is provided.
Changes:
regression-test.py: Change default behavior (no--matrix/ no--checklist) from thertl-bothmatrix preset to single-mode inheritingVENTUS_BACKEND, with checklist defaulting toall; update related help text/comments.build-ventus.sh: Auto-detect NVIDIA driver availability; skipsbtsimbuild and disable driver PTX support when unavailable.- CI workflow: Update regression-test invocations to explicitly pass checklists and adjust timeout scales for slower backends.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
regression-test.py |
Adjusts default CLI behavior to single-mode (inherits VENTUS_BACKEND) and updates --matrix help/commentary accordingly. |
build-ventus.sh |
Adds NVIDIA driver detection and conditionally skips sbtsim / disables PTX in driver builds when unavailable. |
.github/workflows/every.yml |
Updates CI regression-test commands to match the new default semantics and tunes timeouts/checklists per backend. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [ "${NVIDIA_DRIVER_AVAILABLE}" = "false" ]; then | ||
| echo "WARNING:*************************************************************" | ||
| echo | ||
| echo "NVIDIA driver not found. Skipping sbtsim (SBT PTX translator) build." | ||
| echo "If you need sbtsim, please install the NVIDIA driver and try again." |
There was a problem hiding this comment.
The NVIDIA-driver check runs at script startup and emits this "Skipping sbtsim" warning whenever no driver is detected, even if the current invocation isn’t building sbtsim/ptx targets (e.g. --build llvm). Consider only printing this warning when sbtsim/ptx (or driver PTX support) is actually requested/needed based on PROGRAMS_TOBUILD.
else分支:既不给--matrix也不给--checklist时,不再强制走rtl-both,改为单模式继承VENTUS_BACKEND环境变量,checklist 默认all--matrixhelp 文字