Fix for Missed 'readonly' opportunity#17
Merged
Lawrence Lucas Large (LukeLarge) merged 1 commit intomainfrom Mar 14, 2026
Merged
Fix for Missed 'readonly' opportunity#17Lawrence Lucas Large (LukeLarge) merged 1 commit intomainfrom
Lawrence Lucas Large (LukeLarge) merged 1 commit intomainfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Lawrence Lucas Large <162439255+LukeLarge@users.noreply.github.com>
Collaborator
Author
Lawrence Lucas Large (LukeLarge)
left a comment
Lawrence Lucas Large (LukeLarge)
left a comment
There was a problem hiding this comment.
Fix for Missed 'readonly' opportunity
#17
There was a problem hiding this comment.
Pull request overview
Marks the isManagedIdentity field as readonly to reflect its immutability after construction and prevent accidental reassignment.
Changes:
- Updated
isManagedIdentityfield to bereadonly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the problem, mark the
isManagedIdentityfield asreadonly, since it is only assigned at declaration and in the constructor. This conveys that the value is immutable after construction and guards against future accidental modification.Concretely, in
src/devhostagent/PortForward/ServicePortForwardConnector.cs, update the field declaration on line 31 fromprivate bool isManagedIdentity = false;toprivate readonly bool isManagedIdentity = false;. No other code changes, imports, or method additions are required, as assignments in the constructor are permitted forreadonlyfields.Suggested fixes powered by Copilot Autofix. Review carefully before merging.