Skip to content

Fix Synopsys workflow: remove spacing inconsistencies, replace placeholders, add error handling #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: LukeLarge-patch-1
Choose a base branch
from
Open

Fix Synopsys workflow: remove spacing inconsistencies, replace placeholders, add error handling #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
619813b
Initial plan
Copilot Dec 9, 2025
294e044
Fix workflow issues: spacing, placeholders, and error handling
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/synopsys-io.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ jobs:
- name: Static Analysis with Polaris
if: ${{steps.prescription.outputs.sastScan == 'true' }}
run: |
export POLARIS_SERVER_URL=${{ secrets.POLARIS_SERVER_URL}}
export POLARIS_ACCESS_TOKEN=${{ secrets.POLARIS_ACCESS_TOKEN}}
wget -q ${{ secrets.POLARIS_SERVER_URL}}/api/tools/polaris_cli-linux64.zip
set -e
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -e is likely redundant in GitHub Actions run: steps on Linux runners (the default bash invocation is typically already -e and -o pipefail). Consider removing this to avoid implying behavior changes that may already be present, or add a brief comment explaining why it’s needed here (e.g., if shell: is overridden elsewhere).

Suggested change
set -e

Copilot uses AI. Check for mistakes.
export POLARIS_SERVER_URL=${{secrets.POLARIS_SERVER_URL}}
export POLARIS_ACCESS_TOKEN=${{secrets.POLARIS_ACCESS_TOKEN}}
wget -q ${{secrets.POLARIS_SERVER_URL}}/api/tools/polaris_cli-linux64.zip
Comment on lines +47 to +49
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These unquoted expansions can break the shell script if the secret values contain characters significant to the shell (spaces, &, ?, etc.). Quote the assigned values and the URL used by wget (or use the exported POLARIS_SERVER_URL variable) to ensure the command behaves correctly for all valid secret contents.

Suggested change
export POLARIS_SERVER_URL=${{secrets.POLARIS_SERVER_URL}}
export POLARIS_ACCESS_TOKEN=${{secrets.POLARIS_ACCESS_TOKEN}}
wget -q ${{secrets.POLARIS_SERVER_URL}}/api/tools/polaris_cli-linux64.zip
export POLARIS_SERVER_URL="${{secrets.POLARIS_SERVER_URL}}"
export POLARIS_ACCESS_TOKEN="${{secrets.POLARIS_ACCESS_TOKEN}}"
wget -q "${POLARIS_SERVER_URL}/api/tools/polaris_cli-linux64.zip"

Copilot uses AI. Check for mistakes.
unzip -j polaris_cli-linux64.zip -d /tmp
/tmp/polaris analyze -w

Expand All @@ -55,7 +56,7 @@ jobs:
if: ${{steps.prescription.outputs.scaScan == 'true' }}
uses: blackducksoftware/github-action@9ea442b34409737f64743781e9adc71fd8e17d38
with:
args: '--blackduck.url="${{ secrets.BLACKDUCK_URL}}" --blackduck.api.token="${{ secrets.BLACKDUCK_TOKEN}}" --detect.tools="SIGNATURE_SCAN,DETECTOR"'
args: '--blackduck.url="${{secrets.BLACKDUCK_URL}}" --blackduck.api.token="${{secrets.BLACKDUCK_TOKEN}}" --detect.tools="SIGNATURE_SCAN,DETECTOR"'
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expression formatting is inconsistent (some use ${{secrets.X}}, others ${{ github.* }} with spaces). Consider standardizing to a single style across the workflow (commonly ${{ secrets.X }} / ${{ github.X }}) to reduce churn and make future diffs easier to review.

Copilot uses AI. Check for mistakes.

- name: Synopsys Intelligent Security Scan
if: ${{ steps.prescription.outputs.sastScan == 'true' || steps.prescription.outputs.scaScan == 'true' }}
Expand All @@ -64,9 +65,10 @@ jobs:
ioServerUrl: ${{secrets.IO_SERVER_URL}}
ioServerToken: ${{secrets.IO_SERVER_TOKEN}}
workflowServerUrl: ${{secrets.WORKFLOW_SERVER_URL}}
additionalWorkflowArgs: --IS_SAST_ENABLED=${{steps.prescription.outputs.sastScan}} --IS_SCA_ENABLED=${{steps.prescription.outputs.scaScan}}
--polaris.project.name={{PROJECT_NAME}} --polaris.url=${{secrets.POLARIS_SERVER_URL}} --polaris.token=${{secrets.POLARIS_ACCESS_TOKEN}}
--blackduck.project.name={{PROJECT_NAME}}:{{PROJECT_VERSION}} --blackduck.url=${{secrets.BLACKDUCK_URL}} --blackduck.api.token=${{secrets.BLACKDUCK_TOKEN}}
additionalWorkflowArgs: >-
--IS_SAST_ENABLED=${{steps.prescription.outputs.sastScan}} --IS_SCA_ENABLED=${{steps.prescription.outputs.scaScan}}
--polaris.project.name=${{ github.event.repository.name }} --polaris.url=${{secrets.POLARIS_SERVER_URL}} --polaris.token=${{secrets.POLARIS_ACCESS_TOKEN}}
--blackduck.project.name=${{ github.event.repository.name }}:${{ github.ref_name }} --blackduck.url=${{secrets.BLACKDUCK_URL}} --blackduck.api.token=${{secrets.BLACKDUCK_TOKEN}}
Comment on lines 65 to +71
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expression formatting is inconsistent (some use ${{secrets.X}}, others ${{ github.* }} with spaces). Consider standardizing to a single style across the workflow (commonly ${{ secrets.X }} / ${{ github.X }}) to reduce churn and make future diffs easier to review.

Copilot uses AI. Check for mistakes.
stage: "WORKFLOW"

- name: Upload SARIF file
Expand Down
Loading