Skip to content

Add error handling to Synopsys workflow wget and unzip commands #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: LukeLarge-patch-1
Choose a base branch
from
Open

Add error handling to Synopsys workflow wget and unzip commands #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9501b78
Initial plan
Copilot Dec 9, 2025
bbaad05
Add error handling to wget and unzip commands
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/synopsys-io.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
- name: Static Analysis with Polaris
if: ${{steps.prescription.outputs.sastScan == 'true' }}
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -o pipefail is shell-dependent (works in bash, not in plain sh). To ensure consistent behavior across runners/config, explicitly set the step shell to bash (e.g., add shell: bash to this step).

Suggested change
if: ${{steps.prescription.outputs.sastScan == 'true' }}
if: ${{steps.prescription.outputs.sastScan == 'true' }}
shell: bash

Copilot uses AI. Check for mistakes.
run: |
set -e
set -o pipefail
export POLARIS_SERVER_URL=${{ secrets.POLARIS_SERVER_URL}}
export POLARIS_ACCESS_TOKEN=${{ secrets.POLARIS_ACCESS_TOKEN}}
wget -q ${{ secrets.POLARIS_SERVER_URL}}/api/tools/polaris_cli-linux64.zip
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secret-expanded values should be quoted to avoid word-splitting/globbing if the URL/token contain special characters. Also, since POLARIS_SERVER_URL is exported, prefer using it for the wget URL to avoid duplicating the secret expression (and keep the command consistent with the exported env var).

Suggested change
wget -q ${{ secrets.POLARIS_SERVER_URL}}/api/tools/polaris_cli-linux64.zip
wget -q "${POLARIS_SERVER_URL}/api/tools/polaris_cli-linux64.zip"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using wget -q can suppress useful diagnostics in logs, which works against the stated goal of providing clearer error context when downloads fail. Consider using a less-silent mode (e.g., -nv) or removing -q so failures are easier to diagnose from workflow output.

Suggested change
wget -q ${{ secrets.POLARIS_SERVER_URL}}/api/tools/polaris_cli-linux64.zip
wget -nv ${{ secrets.POLARIS_SERVER_URL}}/api/tools/polaris_cli-linux64.zip

Copilot uses AI. Check for mistakes.
Expand Down
Loading