Potential fix for code scanning alert no. 4: Workflow does not contain permissions#22
Open
Lawrence Lucas Large (LukeLarge) wants to merge 1 commit intomainfrom
Open
Potential fix for code scanning alert no. 4: Workflow does not contain permissions#22Lawrence Lucas Large (LukeLarge) wants to merge 1 commit intomainfrom
Lawrence Lucas Large (LukeLarge) wants to merge 1 commit intomainfrom
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Lawrence Lucas Large <162439255+LukeLarge@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Restricts the default GITHUB_TOKEN permissions for the build job in the npm publish workflow to address code scanning alert #4 by applying least-privilege permissions.
Changes:
- Add an explicit
permissionsblock tojobs.build. - Set
contents: readfor the build job to avoid unnecessary write scopes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TLMSLLC/ton-preprocessed-wallet-v2/security/code-scanning/4
In general, fix this by explicitly setting
permissionsfor each job (or at the workflow root) so thatGITHUB_TOKENhas only the minimal required scopes. Jobs that just build and test usually only need read access to contents (and sometimes to packages); jobs that publish packages or modify repo state can request the additional write scopes they need.For this workflow, leave the existing
permissionsblock onpublish-gprunchanged, because it already usescontents: readandpackages: write, which are appropriate for publishing to GitHub Packages. Add a newpermissionsblock to thebuildjob directly under its job definition (e.g., underruns-on) that restricts permissions tocontents: read. This matches CodeQL’s suggested minimal starting point and does not change functional behavior for thebuildjob, sincenpm ciandnpm testdo not require write access to the repository or other GitHub resources.Concretely:
.github/workflows/npm-publish-github-packages.yml.jobs.build, add:runs-on: ubuntu-latestandsteps:. No new imports or dependencies are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.