Conversation
Geojson Named Layer files must be set up such that the single object in the 'objects' attribute is titled the same as the prefix of the filename. So, for the new Reservoirs.json file, we changed the title of the first (only) object in the objects list to 'Reservoirs' instead of 'Reservoirs_Fin_FeaturesToJSO'. Similar changes were made to TX_HUC08_Watersheds.json
Calling fitBounds() after _setPreviousBBBox() overrides the default_extent in a bad way. Why were these adde after every call to _setPreviousBBBox()? https://github.com/TNRIS/ckanext-spatial/blame/8c011c7eb2356281b6f438461637bd16c46e9e0e/ckanext/spatial/public/js/spatial_query.js#L194 Good for contribution upstream?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.