Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
ModularUI を 3.1.5 に更新し、3.1.5 での Widget#getCurrentBackground シグネチャ変更に起因するクラッシュを解消しつつ、UI 周りの非推奨 API(Column/Row や align/alignment 等)を新 API に置き換える PR です。
Changes:
- ModularUI 依存を
3.1.4→3.1.5に更新 ButtonToggleable#getCurrentBackgroundの override シグネチャを 3.1.5 に合わせてクラッシュを修正- 画面レイアウト/テキスト配置/プログレス同期の非推奨 API を
Flow.*/center|right|bottom|textAlign|syncHandlerへ移行
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/io/github/trcdevelopers/clayium/integration/modularui/ItemSlotBuilder.kt | align(Alignment.Center) を center() に置換 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/multiblock/RedstoneProxyMetaTileEntity.kt | CycleButton の中央寄せ API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/multiblock/CaReactorMetaTileEntity.kt | align/alignment を位置指定 + textAlign に移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/WaterwheelMetaTileEntity.kt | Column → Flow.column、各種 align を位置指定に置換 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/VoidContainerMetaTileEntity.kt | スロットの中央寄せ API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/StorageContainerMetaTileEntity.kt | Column → Flow.column、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/SolarClayFabricatorMetaTileEntity.kt | Row → Flow.row、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/ResonatingCollectorMetaTileEntity.kt | テキスト揃えを textAlign へ、中心配置を center() へ移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/RangedReplacerMetaTileEntity.kt | Column → Flow.column、各種 align* を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/RangedMinerMetaTileEntity.kt | CE スロットの配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/PanDuplicatorMetaTileEntity.kt | Row → Flow.row、進捗バー配置/同期 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/PanCoreMetaTileEntity.kt | Column → Flow.column、Rectangle.setColor → color へ移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/PanAdapterMetaTileEntity.kt | Row → Flow.row、右上寄せ等の配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/EnergyConverterMetaTileEntity.kt | Column → Flow.column、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/DistributorMetaTileEntity.kt | Row/Column → Flow.row/Flow.column へ移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/ClayFabricatorMetaTileEntity.kt | Row → Flow.row、中心配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/ChemicalMetalSeparatorMetaTileEntity.kt | Row → Flow.row、テキスト揃えを textAlign に移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/CentrifugeMetaTileEntity.kt | Row → Flow.row、align/alignment を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/AutoTraderMetaTileEntity.kt | Row/Column → Flow.*、相対/中央寄せ API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/AutoCrafterMetaTileEntity.kt | alignY/align を verticalCenter/right 等に更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/metatileentities/AutoClayCondenserMetaTileEntity.kt | Row → Flow.row、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/items/filter/ItemStringItemFilter.kt | Column → Flow.column、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/items/filter/ItemSimpleItemFilter.kt | Column → Flow.column、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/items/filter/ItemFuzzyItemFilter.kt | Column → Flow.column、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/gui/ButtonToggleable.kt | getCurrentBackground override を ModularUI 3.1.5 シグネチャへ更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/blocks/metalchest/TileEntityMetalChest.kt | Column → Flow.column、childIf の新シグネチャ等に対応 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/blocks/clayworktable/TileClayWorkTable.kt | 進捗表示を DoubleSyncValue + ProgressWidget.syncHandler 方式へ移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/common/blocks/TileEntityCreativeEnergySource.kt | Column → Flow.column、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/multiblock/MultiblockLogic.kt | テキスト揃えを textAlign に移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/multiblock/ClayReactorMetaTileEntity.kt | テキスト揃え/中央寄せ API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/multiblock/ClayBlastFurnaceMetaTileEntity.kt | 下中央寄せを horizontalCenter().bottom(0) へ更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/WorkableMetaTileEntity.kt | Row → Flow.row、childIf 新シグネチャ等に対応 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/MultiTrackBufferMetaTileEntity.kt | Row/Column → Flow.*、パネル中央寄せ API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/MetaTileEntity.kt | columnWithPlayerInv を Flow.column() ベースへ更新、標準ヘッダ配置 API 更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/ClayLaserMetaTileEntity.kt | CE スロット配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/ClayBufferMetaTileEntity.kt | Column → Flow.column、配置 API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/AbstractMinerMetaTileEntity.kt | テキスト揃え/中央寄せ API を更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/AbstractItemGeneratorMetaTileEntity.kt | 中央寄せ API を center() に更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/metatileentity/AbstractBuilderMetaTileEntity.kt | 上中央寄せを horizontalCenter() に更新 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/capability/impl/LaserEnergyHolder.kt | テキスト揃えを textAlign に移行 |
| src/main/kotlin/io/github/trcdevelopers/clayium/api/capability/AbstractWorkable.kt | 進捗表示を DoubleSyncValue + ProgressWidget.syncHandler 方式へ移行 |
| gradle/scripts/mod_dependencies.gradle | ModularUI 依存を 3.1.5 に更新 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implementation Details
今回のクラッシュは、3.1.5で
WidgetのgetCurrentBackgroundメソッドのシグネチャが変わったことにより発生していた。ButtonTogleableでそのメソッドをoverrideしていたため、シグネチャを合わせた。