[WIP] Improve document types domain#591
Open
pepetreshere wants to merge 58 commits into2022-05-AC-IMP-l10n_ec_standardfrom
Open
[WIP] Improve document types domain#591pepetreshere wants to merge 58 commits into2022-05-AC-IMP-l10n_ec_standardfrom
pepetreshere wants to merge 58 commits into2022-05-AC-IMP-l10n_ec_standardfrom
Conversation
Data improvements: - Added missing tax groups - Added VAT 8%, used for tourism operations on special hollidays - Fixes base percentage on Withhold VAT taxes - Corrected tax name from Iva to IVA - Improves SRI paymment options, with sequence widget and inactavtes deprecated payment options. - Fixes short code of document types - Corrects document type name for insurance - Adds withhold document type, to be implemented in separated module Other improvements: - Automatic setup of several journals when creating new companies - Adds restrictions to ensure proper setup of ecuadorian journals - Improves ecuadorian journal form More improvements: - Removes unused fiscal positions - Removes unnecessary journals - Desactivates unused payment methods - Adds migration scripts - Add SRI Root menu - More fixes and improvements Co-authored-by: Andres Calle <andres.calle@trescloud.com>
- Improved fiscal positions - Removed overkilling constraints - Removed new fields in payment methods SRI - Removed unnecesary migration scripts - Fixed Indentation - Fixed authors
As the is_invoice trick was not authorized by Odoo, then another method should be used for sending emails from withholds
Added support for withholds and removed unsupported scenario for exports
In Latam some purchase documents (such as purchase liquidation) are issued by the company as an EDI document, even more some sales documents are issued by the customer (such as the sale withhold). To easily support those scenarios we improve the logic for validation of third party documents.
The invoice number uniqueness validation in Latam will depend mainly if the document is issued by the company or from a third party. Note that in EC, CL, PE, some electronic purchase documents can be issued by the company itself to accomodate suppliers withoud electronic documents.
It will help Odoo decide if the document should be manually numbered or auto numbered in Ecuador, usefull por purchase liquidations
Maybe should be removed from this PR, but to illustrate the benefit of attemped change. It is a theorical change, not tested!
…KyV08kl90ALV9OUr0CyXkf23IMRuc@github.com/TRESCLOUD/odoo.git into 2022-05-AC-IMP-l10n_ec_standard
Adds the most common ocurrences of purchase VAT taxes by its tax support, to be easily used in withholds 2.0
Before it was calling twice to _get_last_sequence_domain(). BTW relaxed is False by default, so no need to explicit set as False
Previously more document types than necesary where shown
[IMP] Now comments in data files are in lowercase
For vat withhold taxes, replace factor_percent=12% with factor_percent=100%
[FIX] Tax 541 fixed and fixes to the xml form
Just keep the strictly neccesary
…KyV08kl90ALV9OUr0CyXkf23IMRuc@github.com/TRESCLOUD/odoo.git into 2022-05-AC-IMP-l10n_ec_standard
[IMP] Cosmetic fixes to the code
[IMP] Added journals use the current company emission address
…KyV08kl90ALV9OUr0CyXkf23IMRuc@github.com/TRESCLOUD/odoo.git into 2022-05-AC-IMP-l10n_ec_standard
Improve how to catch identification types for foreign companies and final consumer
Author
|
In sales, for partners with identification type VAT, the _get_l10n_latam_documents_domain is showing too many document types because it doesn't match any identification type (also fails for passport for residents and passport for foreigners, it was failing in a similar not the same way in the older version too, it also fails for identification types of other countires). This PR solves the issue, but needs a bit of discussion, I can show on our next meeting |
odoostan
force-pushed
the
2022-05-AC-IMP-l10n_ec_standard
branch
from
4961dbf to
f860418
Compare
odoostan
force-pushed
the
2022-05-AC-IMP-l10n_ec_standard
branch
2 times, most recently
from
1586c79 to
85ad62d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve how to catch identification types for foreign companies and final consumer