Open
Conversation
Collaborator
|
Hey @Ombrini I just noticed your PR, thanks for adding this. Can you also add a regression test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this branch, I uploaded the model for NMC811 developed to simulate the system for: A phase inversion strategy for low-tortuosity and ultrahigh-mass-loading nickel-rich layered oxide electrodes, May 09, 2024 https://doi.org/10.1016/j.xcrp.2024.101972
In the model, the concentration-dependent exchange current density and the concentration-dependent diffusivity are taken from other studies mentioned in the code and the paper.