Open
Conversation
for save fixed date
honeyl3ee
reviewed
Dec 15, 2023
src/main/java/TripAmi/backend/app/banner/infra/BannerServiceImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public List<BannerDto> findAll() { |
Contributor
There was a problem hiding this comment.
메서드 명 findBanners로 수정하면 더 명확할 것 같아요. 위에 findById도 마찬가지요.
Contributor
Author
There was a problem hiding this comment.
여러 데이터 가져오는 메서드는 findBanners 처럼 복수형 엔티티이름으로 끝나게 수정했습니다. 근데 findById는 괜찮을거 같아요.
ex) bannerService.findById() 로 되니까 그렇게 생각헀는데 어떠세요?
| this.isOpened = true; | ||
| } | ||
|
|
||
| public void update(String title, String imgUrl) { |
Contributor
There was a problem hiding this comment.
faq처럼 updateBanner 이런 식으로 메서드명 통일하면 좋겠습니다
Contributor
Author
There was a problem hiding this comment.
faq.update() 처럼 되서 banner 도 updateBanner 가 아닌 그냥 update로 바꾸고 싶은데 어떠세요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.