Unstable: Add version of imtime_bubble_chi0_wk that allows for two Green's function inputs. #47
Open
andrewkhardy wants to merge 2 commits intoTRIQS:unstablefrom
Open
Unstable: Add version of imtime_bubble_chi0_wk that allows for two Green's function inputs. #47andrewkhardy wants to merge 2 commits intoTRIQS:unstablefrom
andrewkhardy wants to merge 2 commits intoTRIQS:unstablefrom
Conversation
added 2 commits
August 7, 2024 11:26
Member
|
Dear Andrew, Thank you for the contribution. Could we discuss the big picture in your feature request #46 before I work on giving you feedback on this pull request? Best, Hugo |
Author
|
@HugoStrand I still believe this is useful for the case of genuinely different Green's functions, but if you'd prefer to maintain the block Green's function approach for your code, I'll close both this and the "issue". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should implement my Feature Request