Skip to content

[BUGFIX] prevent undefined key access #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 12.x
Choose a base branch
from
Open

[BUGFIX] prevent undefined key access #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
509a60a
[BUGFIX] prevent undefined key access
mxsteini Oct 23, 2025
b4910d6
[BUGFIX] prevent undefined key access
mxsteini Oct 23, 2025
87539d1
[BUGFIX] prevent undefined functioncall on missing translations
mxsteini Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Classes/Module/DmailController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,7 @@ protected function sendMail($row)
} elseif ($this->cmd == DmailCmdEnum::SendMailTest->value) {
// step 4, sending test personalized test emails
// setting Testmail flag
$htmlmail->setTestmail((bool)$this->params['testmail']);
$htmlmail->setTestmail((bool)($this->params['testmail'] ?? false));

if ($this->tt_address_uid) {
// personalized to tt_address
Expand Down
8 changes: 4 additions & 4 deletions Classes/Plugin/DirectMail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,11 +741,11 @@ public function renderImages(array $imagesArray, string $fieldname): string

// create the image, imagelink and image caption block
foreach ($imagesArray as $k => $image) {
if (strlen(trim($image['image'])) > 0) {
if (array_key_exists('image', $image) && strlen(trim($image['image'])) > 0) {
$lines[] = $image['image'];
if ($image['link']) {
$theLink = $this->getLink($image['link']);
if ($theLink) {
if (array_key_exists($fieldname . '.', $this->conf) && $theLink) {
$lines[] = $this->getString($this->conf[$fieldname . '.']['linkPrefix']) . $theLink;
}
}
Expand All @@ -758,7 +758,7 @@ public function renderImages(array $imagesArray, string $fieldname): string
$imageExists = true;
}
}
if ($this->conf[$fieldname . '.']['header'] && $imageExists) {
if (array_key_exists($fieldname . '.', $this->conf) && $this->conf[$fieldname . '.']['header'] && $imageExists) {
array_unshift($lines, $this->getString($this->conf[$fieldname . '.']['header']));
}

Expand Down Expand Up @@ -825,7 +825,7 @@ public function getString(string $str): string
*/
public function userProcess(string $mConfKey, $passVar)
{
if ($this->conf[$mConfKey]) {
if ($this->conf[$mConfKey] ?? false) {
$funcConf = $this->conf[$mConfKey . '.'];
$funcConf['parentObj']=&$this;
$passVar = $GLOBALS['TSFE']->cObj->callUserFunction(
Expand Down
2 changes: 1 addition & 1 deletion Classes/SelectCategories.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function getLocalizedCategories(array &$params): void
$lang = $this->getLang();

$site = $params['site'];
$languages = $site->getAllLanguages();
$languages = $site->getAllLanguages() ?? [];
foreach($languages as $language) {
if($language->getLocale()->getLanguageCode() == $lang) {
$sysLanguageUid = $language->getLanguageId();
Expand Down