Added "Delay" functionality to the public schedule #2802
Open
JWPCode wants to merge 1 commit intoTabbycatDebate:developfrom
Open
Added "Delay" functionality to the public schedule #2802JWPCode wants to merge 1 commit intoTabbycatDebate:developfrom
JWPCode wants to merge 1 commit intoTabbycatDebate:developfrom
Conversation
…is displayed on the public page
tienne-B
reviewed
Jan 23, 2026
Member
tienne-B
left a comment
tienne-B
left a comment
There was a problem hiding this comment.
Looks good and it's a good start for automatic calculations! Just got a few typos to fix.
|
|
||
| @property | ||
| def delay(self): | ||
| """Returns an intiger representing how delayed the tournament is in minutes.""" |
Member
There was a problem hiding this comment.
Suggested change
| """Returns an intiger representing how delayed the tournament is in minutes.""" | |
| """Returns an integer representing how delayed the tournament is in minutes.""" |
|
|
||
| delayed_starts = [] | ||
| for ev in schedule_events: | ||
| defualt_start = timezone.localtime(ev.start_time) |
Member
There was a problem hiding this comment.
Suggested change
| defualt_start = timezone.localtime(ev.start_time) | |
| default_start = timezone.localtime(ev.start_time) |
| delayed_starts.append(delayed_time.strftime("%H:%M") + f" (+{self.tournament.delay} minutes)") | ||
|
|
||
| if delayed_starts.count("") != len(delayed_starts): | ||
| self.add_column({'title': _("Delayed Start Time"), 'key': _("Delayed Start")}, delayed_starts) |
Member
There was a problem hiding this comment.
Suggested change
| self.add_column({'title': _("Delayed Start Time"), 'key': _("Delayed Start")}, delayed_starts) | |
| self.add_column({'title': _("Delayed Start Time"), 'key': 'delayed'}, delayed_starts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we know debating tournaments rarely run on time, and I saw on the gitHub the intention to have the public schedule update with how late the tournament is running. This PR lays the ground work for having the delay automatically calculated, with changes to models and adding a delay property to the tournament. Currently this allows the Tab team to manually set the delay, witch will be shown next to the events that day. I think the UX could use some work and welcome any feedback on changes before closing this PR