Skip to content

feat: added configurable poll_interval for web3#21

Merged
0xThemis merged 1 commit intomainfrom
themis/add_configure_poll_interval
Mar 17, 2026
Merged

feat: added configurable poll_interval for web3#21
0xThemis merged 1 commit intomainfrom
themis/add_configure_poll_interval

Conversation

@0xThemis
Copy link
Member

@0xThemis 0xThemis commented Mar 17, 2026

Note

Medium Risk
Moderate risk because it changes RPC client confirmation polling behavior, which can affect transaction confirmation latency and RPC load if misconfigured.

Overview
Adds confirmations_poll_interval to RpcProviderConfig (serde/humantime deserializable) and threads it through RpcProviderBuilder.

When set, build() applies the interval via RpcClient::with_poll_interval; defaults remain unchanged when omitted, and the config/builder defaults now initialize the field to None.

Written by Cursor Bugbot for commit 7457115. This will update automatically on new commits. Configure here.

@0xThemis 0xThemis force-pushed the themis/add_configure_poll_interval branch 2 times, most recently from b0d9741 to 4d4d9f9 Compare March 17, 2026 13:36
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@0xThemis 0xThemis force-pushed the themis/add_configure_poll_interval branch from 4d4d9f9 to 7457115 Compare March 17, 2026 13:41
@0xThemis 0xThemis merged commit 641296d into main Mar 17, 2026
5 checks passed
@0xThemis 0xThemis deleted the themis/add_configure_poll_interval branch March 17, 2026 14:03
@taceo-bot taceo-bot mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants