Skip to content

feat: add animation duration option #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zvandermeer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add animation duration option #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ type DragAxis = 'x' | 'y' | 'both'

export type Config = {
animation: AnimationType
animationDuration: number | undefined
enabled: boolean
swapMode: 'hover' | 'drop'
dragOnHold: boolean
Expand All @@ -151,6 +152,7 @@ export type Config = {

const DEFAULT_CONFIG: Config = {
animation: 'dynamic',
animationDuration: undefined,
enabled: true,
swapMode: 'hover',
dragOnHold: false,
Expand All @@ -159,14 +161,17 @@ const DEFAULT_CONFIG: Config = {
manualSwap: false
}

function getAnimateConfig(animationType: AnimationType): AnimateConfig {
function getAnimateConfig(
animationType: AnimationType,
animationDuration: number | undefined
): AnimateConfig {
switch (animationType) {
case 'dynamic':
return { easing: easeOutCubic, duration: 300 }
return { easing: easeOutCubic, duration: animationDuration ?? 300 }
case 'spring':
return { easing: easeOutBack, duration: 350 }
return { easing: easeOutBack, duration: animationDuration ?? 350 }
case 'none':
return { easing: (t: number) => t, duration: 1 }
return { easing: (t: number) => t, duration: animationDuration ?? 1 }
}
}

Expand Down Expand Up @@ -868,7 +873,10 @@ function createItem(itemEl: HTMLElement, store: Store): Item {
continuousDrag = true
}
},
getAnimateConfig(store.config().animation)
getAnimateConfig(
store.config().animation,
store.config().animationDuration
)
)
}
})
Expand Down Expand Up @@ -1018,7 +1026,10 @@ function createSyncUpdate() {
function animateFlippedItem(item: Item, flip: Flip) {
item.cancelAnimation().moveToSlot?.()
item.cancelAnimation().drop?.()
const animateConfig = getAnimateConfig(item.store().config().animation)
const animateConfig = getAnimateConfig(
item.store().config().animation,
item.store().config().animationDuration
)

const transitionValues = flip.transitionValues()

Expand Down