-
Notifications
You must be signed in to change notification settings - Fork 52
feat(TMC-15843): disabled item in datalist #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bf2410b
2e9e2e0
4eb7bfb
f4acaef
012b409
2b463e0
f3dd483
755ebf3
39a933d
8360695
645715b
0fc3fbf
f780d25
1835c97
d5648cb
7c9516b
e832f27
fedac51
8901735
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,8 +138,9 @@ export function renderItem(item, { value }) { | |
| title = (item.title || item.name || '').trim(); | ||
| description = item.description; | ||
| } | ||
|
|
||
| return ( | ||
| <div className={theme.item} title={title}> | ||
| <div className={classNames(theme.item, { [theme.disabled]: item.disabled })} title={title}> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typeahead has its own wrapper to display each item (which has the onClick handler) so you can pass You can take a look at #1993 for an example
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, thanks |
||
| <span className={classNames(theme['item-title'], 'tc-typeahead-item-title')}> | ||
| <Emphasis value={value} text={title} /> | ||
| </span> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to follow that PR I guess moroshko/react-autowhatever#35
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, also saw that PR, but it was done more than a year ago (
And as there is no any activity on that PR, there is not guarantee that we will get such functionality til release
But we can follow of course