Add player relationships API + sample

[tudddorrr]

No description provided.

[claude]

Code Review: Player Relationships API

---

🔴 Critical Issues

Memory leak - Event handler never unsubscribed (PlayerRelationshipsAPI.cs:96)

The socket event handler is registered in the constructor but never cleaned up:

public PlayerRelationshipsAPI() : base("v1/players/relationships")
{
    Talo.Socket.OnMessageReceived += HandleSocketMessage;
}

This means every time a PlayerRelationshipsAPI instance is created, a new handler is added to Talo.Socket.OnMessageReceived, but these handlers are never removed. If the API is instantiated multiple times (unlikely given the singleton pattern in Talo.cs, but possible in tests or edge cases), this causes a memory leak and duplicate event firing.

Fix: Add cleanup, similar to how other resources are managed. Consider implementing IDisposable or adding an internal cleanup method called by TaloManager.

---

🔵 Minor Issues

Code duplication in query string builders (PlayerRelationshipsAPI.cs:30-51, 62-83)

GetSubscribersOptions.ToQueryString() and GetSubscriptionsOptions.ToQueryString() are identical implementations. This violates DRY and makes maintenance harder.

Fix: Extract to a shared base class or helper method:

public abstract class BaseSubscriptionOptions
{
    public int page = 0;
    public ConfirmedFilter confirmed = ConfirmedFilter.Any;
    public int aliasId = -1;
    public RelationshipTypeFilter relationshipType = RelationshipTypeFilter.Any;
    
    public string ToQueryString() { /* existing implementation */ }
}

public class GetSubscribersOptions : BaseSubscriptionOptions { }
public class GetSubscriptionsOptions : BaseSubscriptionOptions { }

---

Other Categories

Performance considerations: No issues found

Security concerns: No issues found

Backwards compatibility: No issues found (new feature)