Skip to content

Conversation

@crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Aug 23, 2025

This PR adds the Composition API to our Svelte adapter via a createFormRune function.

TODOs

  • Port code
  • Write tests
  • Write docs
  • Write example code

@nx-cloud
Copy link

nx-cloud bot commented Aug 23, 2025

View your CI Pipeline Execution ↗ for commit 8eedea8

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 33s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-30 07:36:28 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 23, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1713

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1713

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1713

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1713

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1713

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1713

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1713

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1713

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1713

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1713

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1713

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1713

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1713

commit: 8eedea8

@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (6892ed0) to head (8eedea8).
⚠️ Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
packages/svelte-form/src/createFormRune.svelte.ts 68.18% 6 Missing and 1 partial ⚠️
packages/svelte-form/src/AppForm.svelte 0.00% 2 Missing ⚠️
packages/svelte-form/src/AppField.svelte 66.66% 1 Missing ⚠️
packages/svelte-form/src/createForm.svelte.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   90.35%   89.87%   -0.49%     
==========================================
  Files          38       46       +8     
  Lines        1752     1886     +134     
  Branches      444      473      +29     
==========================================
+ Hits         1583     1695     +112     
- Misses        149      171      +22     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn crutchcorn force-pushed the svelte-composition-api branch from 231ae85 to b818816 Compare November 30, 2025 07:17
@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2025

⚠️ No Changeset found

Latest commit: 8eedea8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@crutchcorn
Copy link
Member Author

crutchcorn commented Nov 30, 2025

This is now ready to merge! Just waiting for merge reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants