Skip to content

solved Devtools show null instead of NaN #1781 #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −5
Open

solved Devtools show null instead of NaN #1781 #1862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions packages/form-devtools/src/components/DetailsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,25 @@ import { StateHeader } from './StateHeader'

import type { Accessor } from 'solid-js'

const preprocessValue = (value: any): any => {
if (typeof value === 'number' && isNaN(value)) {
return 'NaN'
}
if (Array.isArray(value)) {
return value.map(preprocessValue)
}
if (value !== null && typeof value === 'object') {
const result: any = {}
for (const key in value) {
if (value.hasOwnProperty(key)) {
result[key] = preprocessValue(value[key])
}
}
return result
}
return value
}

type DetailsPanelProps = {
selectedKey: Accessor<string>
}
Expand Down Expand Up @@ -86,7 +105,7 @@ export function DetailsPanel({ selectedKey }: DetailsPanelProps) {
>
{fieldName}
</div>
<JsonTree copyable value={fieldData as unknown} />
<JsonTree copyable value={preprocessValue(fieldData) as unknown} />
</div>
)}
</For>
Expand All @@ -98,15 +117,15 @@ export function DetailsPanel({ selectedKey }: DetailsPanelProps) {
<div class={styles().stateContent}>
<JsonTree
copyable
value={store()[selectedIndex()]!.state.values as unknown}
value={preprocessValue(store()[selectedIndex()]!.state.values) as unknown}
/>
</div>
</div>

<div class={styles().detailSection}>
<div class={styles().detailSectionHeader}>Form status</div>
<div class={styles().stateContent}>
<JsonTree copyable value={formStatus() as unknown} />
<JsonTree copyable value={preprocessValue(formStatus()) as unknown} />
</div>
</div>

Expand All @@ -115,7 +134,7 @@ export function DetailsPanel({ selectedKey }: DetailsPanelProps) {
<div class={styles().stateContent}>
<JsonTree
copyable
value={store()[selectedIndex()]?.options as unknown}
value={preprocessValue(store()[selectedIndex()]?.options) as unknown}
collapsePaths={['validators'] as unknown as never}
/>
</div>
Expand All @@ -126,7 +145,7 @@ export function DetailsPanel({ selectedKey }: DetailsPanelProps) {
<div class={styles().stateContent}>
<JsonTree
copyable
value={store()[selectedIndex()]?.history as unknown}
value={preprocessValue(store()[selectedIndex()]?.history) as unknown}
/>
</div>
</div>
Expand Down