chore(deps): update all non-major dependencies #9628
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
github-actions
bot
added
package: react-query-devtools
package: react-query
package: react-query-persist-client
package: vue-query
package: query-core
package: solid-query
package: query-persist-client-core
package: eslint-plugin-query
package: svelte-query
package: svelte-query-devtools
package: query-devtools
package: angular-query-experimental
package: angular-query-devtools-experimental
package: query-async-storage-persister
labels
WalkthroughBump CI workflow action versions and upgrade many dependency/dev-tool versions across root, examples, integrations, and package manifests. Changes are configuration and dependency version updates only; no source code or runtime control-flow modifications. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing touches🧪 Generate unit tests
Comment Pre-merge checks✅ Passed checks (3 passed)
|
github-actions
bot
added
package: query-sync-storage-persister
package: solid-query-persist-client
package: svelte-query-persist-client
package: vue-query-devtools
package: solid-query-devtools
package: query-broadcast-client-experimental
package: react-query-next-experimental
package: angular-query-persist-client
package: query-test-utils
labels
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 2m 36s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
❌ Failed | 1m 20s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-09-22 13:06:47 UTC
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 20
🧹 Nitpick comments (13)
examples/react/eslint-legacy/package.json (1)
23-26: Align React 19 with @types v19 across all React examples
The following examples depend on React 19 but still reference @types/react@18 and @types/react-dom@18, which can cause type mismatches with TypeScript 5.8:
- examples/react/algolia/package.json
- examples/react/basic/package.json
- examples/react/eslint-legacy/package.json
- examples/react/react-router/package.json
In each, update the devDependencies to:
"@types/react": "^19.0.1", "@types/react-dom": "^19.0.2",.github/workflows/autofix.yml (1)
21-21: Pin actions/checkout to a commit SHA for supply-chain hardening
Optional, but recommended for immutable CI builds.
Example:- uses: actions/checkout@v4.3.0 + uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feacpackages/solid-query/package.json (1)
74-78: Solid toolchain bumps look consistentnpm-run-all2, solid-js, and vite-plugin-solid are aligned with other Solid packages in this PR. Peer range remains "^1.6.0", which is fine but broad; consider tightening the min if features require ≥1.9.
examples/react/algolia/package.json (1)
11-24: Use caret for @algolia/client-search
Replace the pinned version with a caret for consistency:- "@algolia/client-search": "5.37.0", + "@algolia/client-search": "^5.37.0",npm view confirms it requires Node ≥ 14.0.0 and its ESM/CJS exports align with your “type”: “module” + Vite setup.
packages/solid-query-devtools/package.json (1)
68-72: Peer range still valid; optional tighten-upDevDeps bumped (solid-js 1.9.9, vite-plugin-solid 2.11.8). Peer dep on solid-js is "^1.6.0", which covers 1.9.x—no action required. Optionally, document tested range (e.g., “>=1.6 <2”) in README to set expectations.
packages/react-query/package.json (1)
1-87: Add missing Vite devDependencyIn packages/react-query/package.json you have
@vitejs/plugin-react(^4.7.0) but noviteentry—add underdevDependencies:"devDependencies": { - "@vitejs/plugin-react": "^4.7.0" + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.0" }.github/workflows/pr.yml (1)
25-25: Consider pinning GitHub Actions to commit SHAs and adding job timeouts.actions/checkout and nrwl/nx-set-shas are on version tags. For supply‑chain hardening, pin to the release commit SHA with an inline comment for the tag. Also consider
timeout-minuteson jobs to prevent hangs.Also applies to: 33-33, 54-54
packages/solid-query-persist-client/package.json (1)
73-77: Dev deps bumped; peer range remains broad—consider CI matrix for Solid versions.Peer allows solid-js >=1.6 while tests run on 1.9.x. Optional: add a small CI matrix to smoke‑test a lower Solid within the supported peer range to catch regressions.
.github/workflows/ci.yml (1)
30-30: Same as pr.yml: optionally pin actions and add timeouts.Pin actions/checkout to a commit SHA and consider
timeout-minuteson the job/steps for resilience.packages/query-devtools/package.json (1)
67-81: Unifysolid-jsversions across the workspace
Update allsolid-jsentries to the same range (for example,^1.9.9), replacing the older^1.6.0in:
- packages/solid-query/package.json (lines 75 & 80)
- packages/solid-query-persist-client/package.json (lines 74 & 80)
- packages/solid-query-devtools/package.json (lines 69 & 75)
Then runpnpm -w dedupeto collapse duplicate versions in the lockfile.examples/react/rick-morty/package.json (1)
11-14: MUI upgrades OK; consider migrating off @mui/styles (deprecated).@mui/styles is legacy and discouraged for new code; plan a follow-up to replace it (e.g., Emotion/Pigment CSS). This is optional for this Renovate PR. (npmjs.com, mui.com)
package.json (1)
53-55: React Hooks plugin is RCeslint-plugin-react-hooks is on 6.0.0-rc1. If not intentional, prefer a stable tag to avoid churn; otherwise document the reason in the PR description.
- "eslint-plugin-react-hooks": "^6.0.0-rc1", + "eslint-plugin-react-hooks": "^6.0.0" # when GA landsexamples/angular/pagination/package.json (1)
19-19: Unify semver strategy for zone.jsThis example pins zone.js exactly (0.15.1) while other packages use ~0.15.1. Consider aligning to a single strategy for predictability.
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-sync-storage-persister/package.jsonexamples/solid/astro/package.jsonpackages/solid-query-devtools/package.jsonpackages/react-query-persist-client/package.jsonpackages/solid-query/package.jsonpackages/query-persist-client-core/package.jsonpackages/angular-query-persist-client/package.jsonpackages/svelte-query/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/vue-query/package.jsonpackages/react-query-devtools/package.jsonexamples/react/basic-graphql-request/package.jsonpackages/vue-query-devtools/package.jsonpackages/query-core/package.jsonexamples/angular/basic-persister/package.jsonpackages/query-async-storage-persister/package.jsonpackages/react-query/package.jsonpackages/angular-query-experimental/package.jsonintegrations/react-vite/package.jsonintegrations/react-next-15/package.jsonpackages/react-query-next-experimental/package.jsonpackages/solid-query-persist-client/package.jsonexamples/vue/persister/package.jsonpackages/query-broadcast-client-experimental/package.jsonexamples/solid/basic/package.jsonexamples/solid/default-query-function/package.jsonpackages/angular-query-devtools-experimental/package.jsonpackages/svelte-query-devtools/package.jsonexamples/solid/simple/package.jsonpackages/svelte-query-persist-client/package.jsonintegrations/solid-vite/package.jsonpackage.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
PR: TanStack/query#9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (58)
examples/vue/2.7-basic/package.json (1)
17-17: Vite 4.x bump for Vue 2.7 example looks good.No compatibility concerns with vue2 + vite-plugin-vue2 2.0.3.
packages/query-persist-client-core/package.json (1)
66-66: npm-run-all2 patch bump is safe.No script changes needed; CLI remains
npm-run-all.examples/react/shadow-dom/package.json (1)
19-22: Vite 6.3 + plugin-react 4.7 with React 19 types is consistent.This example is already on @types v19; upgrade set looks coherent.
packages/query-test-utils/package.json (1)
38-38: Uniform npm-run-all2 patch bump acknowledged.Matches the repo-wide update pattern.
examples/vue/2.6-basic/package.json (1)
18-18: Vite 4.x patch bump for Vue 2.6 example is fine.Keeps compatibility with vite-plugin-vue2 2.0.3.
examples/react/devtools-panel/package.json (1)
17-20: React devtools-panel: Vite/tooling bumps look consistent.No API or script changes required.
examples/vue/dependent-queries/package.json (1)
15-18: Vite 6.x bump: declare Node >=18 and regenerate lockfileOnly
examples/solid/basic-graphql-request/package.jsondeclaresengines.node(≥18); the root andexamples/vue/dependent-queries/package.jsonlack a Node version constraint. Addengines.node: ">=18"(and update your CI matrix), then reinstall to refresh the lockfile and lock Vite/plugin minors.examples/vue/nuxt3/package.json (1)
13-14: Nuxt upgrade sanity check
Version ^3.19.1 confirmed;nuxt.config.tscontains nonitro,experimental, orviteflags. Runnpm run dev,npm run build, andnpm run previewto catch any config regressions.examples/svelte/simple/package.json (1)
16-21: Ignore SvelteKit compatibility check for this example
Theexamples/svelte/simplesetup is a plain Svelte template—there’s no@sveltejs/kitdependency or Kit-specific config (noadapter-autoorvitePlugininsvelte.config.js), so verifying SvelteKit defaults isn’t applicable.Likely an incorrect or invalid review comment.
examples/solid/default-query-function/package.json (1)
13-19: Solid/Vite alignment looks goodsolid-js ^1.9.9 with vite ^6.3.5 and vite-plugin-solid ^2.11.8 is a known-good combo. No action beyond lockfile update.
examples/vue/persister/package.json (1)
15-22: Run build & smoke-test forexamples/vue/persister
Verifiedidb-keyvalis ^6.2.2 (no duplicates) and Vite is ^6.3.5 with @vitejs/plugin-vue ^5.2.4—please do a quick install, build, and runtime check to ensure ESM/CJS bundling works.packages/query-core/package.json (1)
61-64: npm-run-all2 bump validated
All package scripts continue to invoke “npm-run-all” (no hardcoded “npm-run-all2” usages detected).examples/solid/astro/package.json (1)
15-22: Approve dependencies bump in examples/solid/astro/package.json
Dependencies align with repo-wide versions (astro 5.5.6, solid-js 1.9.9, @astrojs/solid-js 5.1.0, tailwindcss 3.4.17); no compatibility issues detected.packages/react-query-persist-client/package.json (1)
67-71: Version consistency across workspaces: All instances of@vitejs/plugin-reactare^4.7.0and@testing-library/reactare^16.3.0in everypackage.json—no skew detected.integrations/react-vite/package.json (1)
11-15: Approve code changes: Vite and plugin-react versions are consistent across all React Vite integrations and examples. All scanned package.json files use Vite ^6.3.5 and @vitejs/plugin-react ^4.7.0.packages/react-query-next-experimental/package.json (1)
61-64: Approve dev-only dependency bumps
Vite plugin is imported inpackages/react-query-next-experimental/vite.config.ts, so the@vitejs/plugin-reactdev bump is used and safe; runtime surface remains unchanged.examples/solid/solid-start-streaming/package.json (1)
14-19: Approve: SolidStart 1.1.7 & vinxi 0.5.8 updates
Node >=18 is enforced in examples/solid/solid-start-streaming/package.json; no breaking changes expected.integrations/svelte-vite/package.json (1)
12-13: Approve Svelte/Vite version alignment
All Svelte (^5.38.7) and Vite (^6.3.5) versions are consistent across relevant workspaces and examples; peer ranges in svelte-query packages cover Svelte 5.packages/svelte-query/package.json (1)
50-57: Approve Svelte dev tooling version updates
PeerDependencies already allow Svelte ^5.0.0 and all Svelte examples use ^5.38.7; no breaking changes or CI impact.examples/react/playground/package.json (1)
17-20: Approve React playground toolchain bump – dependencies now align with other React examples; React ^19 verified consistently across all examples and packages.examples/react/suspense/package.json (1)
19-22: Verified Suspense example build with updated Vite/plugin
Suspense example builds successfully using Vite ^6.3.5 and @vitejs/plugin-react ^4.7.0 with no SWC/plugin default regressions or Suspense-related warnings.packages/query-sync-storage-persister/package.json (1)
67-67: LGTM: npm-run-all2 patch bump.Matches repo-wide update; no runtime impact expected.
packages/query-async-storage-persister/package.json (1)
67-67: LGTM: npm-run-all2 patch bump; deps align with learning.@tanstack/query-core is already a workspace dep (per prior learning); safe patch update.
examples/solid/basic-graphql-request/package.json (2)
13-16: Build passed with graphql@16.11.0 & graphql-request@7.2.0—run TS type check
The Solid GraphQL example builds successfully; to catch any tightened type errors, run a full type‐check in the example:pnpm --filter "./examples/solid/basic-graphql-request" exec tsc --noEmit
19-21: Example build is green; verify Vite/Solid plugin version parity
Runcd examples/solid/basic-graphql-request && pnpm install && pnpm run buildto confirm the example builds cleanly, then ensure itsviteandvite-plugin-solidversions align with those in the otherexamples/solid/*/package.json.examples/react/simple/package.json (1)
17-19: examples/react/simple: build passed with Vite 6.3.5 & @vitejs/plugin-react 4.7.0
Build completed successfully with the updated tooling; no further changes required.examples/svelte/optimistic-updates/package.json (1)
15-22: Confirm Node engine ranges and svelte-check compatibility
- @sveltejs/kit 2.37.1 requires Node ≥18.13; vite 6.3.5 supports Node 18.x, 20.x or ≥22; svelte 5.38.7 requires Node ≥18. Ensure your CI matrix covers at least Node 18.13 and 20.x.
- svelte-check 4.3.1 peer-declares
svelte: "^4.0.0 || ^5.0.0-next.0"andtypescript: ">=5.0.0". Stable Svelte 5.38.7 falls outside the prerelease range and will trigger a peer-dependency warning—confirm support for Svelte 5 stable or upgrade to a svelte-check version that officially includes it.examples/react/basic-graphql-request/package.json (1)
13-20: Peer dependencies are compatible
- @vitejs/plugin-react 4.7.0 declares vite '^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0', satisfying vite ^6.3.5.
- graphql-request 7.2.0 declares graphql '14 - 16', satisfying graphql ^16.11.0.
integrations/vue-vite/package.json (1)
13-16: Peer ranges are already compatible
@vitejs/plugin-vue@5.2.4 declares vue^3.2.25(includes 3.4.27) and vite^5.0.0 || ^6.0.0(includes 6.3.5), so no changes required.examples/solid/simple/package.json (1)
13-20: No changes needed: peer dependencies satisfied
vite-plugin-solid@2.11.8 requires vite ^3.0.0‒^7.0.0 and solid-js ^1.7.2; the project’s versions (^6.3.5 and ^1.9.9) satisfy these ranges.integrations/react-webpack-5/package.json (1)
14-19: Approve Babel/Webpack configuration
Peer dependencies for @babel/preset-react@7.27.1 and @babel/preset-env@7.28.3 both support @babel/core >= 7.0.0-0, and the chosen versions align with React 19’s automatic runtime and Webpack 5—no issues.packages/query-broadcast-client-experimental/package.json (1)
61-68: Ensure CJS interop viatest:build
Imports only use ESM-style named exports frombroadcast-channel(no CommonJSrequirefound). Now runnpm run test:buildand verify that the generated CJS bundle resolvesbroadcast-channelcorrectly.examples/angular/devtools-panel/package.json (1)
12-27: Verify @angular/compiler-cli TypeScript peer dependency
All Angular examples pin TS to 5.8.3; confirm that @angular/compiler-cli@20.2.4 peerDependencies.typescript accepts TS 5.8.x (e.g. runnpm view @angular/compiler-cli@20.2.4 peerDependencies.typescript).integrations/react-next-15/package.json (1)
9-9: Temporal polyfill bump is safe.No breaking changes expected for typical usage; Next 15 + React 19 remain unaffected.
packages/angular-query-devtools-experimental/package.json (1)
57-62: Dev Angular bumps LGTM; peer ranges remain wide enough.No runtime deps changed; only dev tooling. Good.
packages/react-query-devtools/package.json (1)
86-91: Aligns with React 19 and Testing Library v16.Peer range already allows ^18 || ^19; this is consistent.
examples/svelte/ssr/package.json (1)
15-22: Svelte/Kit/Vite bumps look consistent.No API surface here; just tooling updates.
packages/react-query/package.json (1)
73-82: Dev tooling bumps look consistent across workspace.React 19 + @types/react 19 + plugin-react 4.7 + Vite 6.3 is a good set.
examples/svelte/star-wars/package.json (1)
15-25: Svelte + Vite bumps look good; verify Node runtime ≥18.Vite 6 and SvelteKit 2 require modern Node. CI likely uses Node 20, but double‑check local/engines consistency to avoid dev-time surprises.
If you want, I can add an engines field or confirm Node versions across the repo.
examples/react/offline/package.json (1)
16-25: Verify MSW registration with bumped dependencies
Run the offline React example (pnpm -w -F @tanstack/query-example-react-offline dev) to confirm service worker registration remains clean under Vite 6.3 with MSW v2.11.1 and react-hot-toast v2.6.0.examples/react/basic/package.json (1)
21-22: Retain @types/react and @types/react-dom
React v19 does not include its own TypeScript definitions—continue installing @types/react and @types/react-dom to ensure proper typings. (19.react.dev, docs.codemod.com)Likely an incorrect or invalid review comment.
packages/svelte-query-devtools/package.json (1)
45-54: Svelte tooling bumps LGTM.Peer range already includes ^5, and the svelte/svelte-check bumps align with Kit/Vite updates elsewhere.
examples/svelte/auto-refetching/package.json (1)
15-16: Confirm uniform versions; manual build & type-check requiredAll Svelte examples (except
simple, which is plain Svelte) now use
• @sveltejs/kit ^2.37.1
• @sveltejs/adapter-auto ^6.1.0
• vite ^6.3.5
• svelte ^5.38.7Run local builds and
svelte-checkagainst TS 5.8.3 to verify plugin/peer compatibility with @sveltejs/vite-plugin-svelte (^5.1.1).examples/react/chat/package.json (1)
17-19: validate Tailwind v4 config in examples/react/chat
Notailwind.config.*orpostcss.config.*found underexamples/react/chat—Tailwind will fall back to its defaults. If you require custom settings, add atailwind.config.jswith acontentarray (replacing any oldpurgekey) and remove any v3-only options.examples/svelte/load-more-infinite-scroll/package.json (1)
15-16: Approve Svelte toolchain bumps – smoke build succeeded
Minimal canary build passed with @sveltejs/adapter-auto@^6.1.0 and @sveltejs/kit@^2.37.1 matching other examples.packages/svelte-query-persist-client/package.json (1)
50-50: Approve changes: eslint-plugin-svelte@^3.12.2 supports ESLint v8.57.1 and above (including v9.x) and our ESLint ^9.35.0 satisfies this (npmjs.com)packages/angular-query-experimental/package.json (1)
71-81: DTS output verified for angular-query-experimental
vite-plugin-dts@4.5.4 correctly generates declaration files with TS 5.8.3—no regressions detected.examples/react/default-query-function/package.json (1)
17-20: Versions confirmed for Vite‐based examplesAll React examples that use Vite list @vitejs/plugin-react ^4.7.0 and vite ^6.3.5. The Next.js and React Native samples intentionally don’t include Vite and can be ignored. A smoke build of default-query-function passed; consider also verifying the basic and chat examples build correctly under TS 5.8.3 to sanity-check fast refresh and the JSX transform.
packages/eslint-plugin-query/package.json (1)
62-70: ESLint 9 + @typescript-eslint 8.42 alignment looks good; Node pinned in .nvmrc to 24.4.1 – verify your CI honors this or explicitly sets Node ≥18.18.0examples/svelte/playground/package.json (1)
15-22: Validate with svelte-check and build smoke test
Run svelte-check viapnpm -C examples/svelte/playground exec svelte-check(or add
"check": "svelte-check"to package.json)
and verifypnpm -C examples/svelte/playground run buildcompletes without errors.
examples/angular/basic-persister/package.json (1)
12-27: Fixexamples/angular/basic-persisterbuild failure
Build is currently failing with an Angular compilation error:Error: ENOENT: no such file or directory, uv_resident_set_memoryfrom the Angular compiler plugin. Investigate and resolve this issue so the example can successfully build and we can validate the persister interop.
⛔ Skipped due to learnings
Learnt from: TkDodo PR: TanStack/query#9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.examples/angular/optimistic-updates/package.json (1)
12-25: Confirm form-related typings with TS 5.8 in a proper environment. Build failed here due to missing/proc/self/statin this sandbox (uv_resident_set_memory error) (stackoverflow.com); Angular 20.2.x supports Node v24.3.0 (angular.dev). Re-run build in CI or a local full-Linux environment to validate strict template type drift.integrations/solid-vite/package.json (1)
11-13: Solid + Vite bumps look fine; ensure CI Node matrix aligns with Vite 6 support.Vite 6 supports Node 18/20/22+. If your CI still runs Node 16/19, adjust it to avoid spurious failures. (main.vite.dev, main.vitejs.dev)
packages/angular-query-persist-client/package.json (1)
60-71: Angular 20.2 devDeps: verify workspace TypeScript ≥5.9 and Node ≥20.19.Angular 20.2.x requires TS >=5.9 and Node >=20.19. If the workspace/root still pins TS 5.8.3, local builds/tests here may fail. (angular.dev)
integrations/react-webpack-4/package.json (1)
14-17: Babel deps upgraded — still compatible with webpack 4.babel-loader 8.x supports webpack 4 and 5; this bump is safe for the v4 example. (webpack.js.org, github.com)
package.json (2)
41-45: ESLint plugin peer dependencies verifiedAll listed plugins resolved against eslint 9.35.0 with no peer-dependency warnings on install.
69-76: CI covers TS 5.x aliases via existingtest:typestarget
Theci.ymlandpr.ymlworkflows runpnpm run test:ci/test:pr, which invoke the NXtest:typestarget across all packages. Each package’stest:typesscript in turn runs itstest:types:ts50–test:types:ts57commands, exercising every TS alias without needing an explicit matrix.integrations/angular-cli-20/package.json (1)
12-21: Angular 20.2.x dependency set looks consistentCore/angular and rxjs/tslib/zone.js versions are in lockstep and match examples. LGTM.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2 upgrade: double-check TypeScript support window.
Angular often pins a TS range. You have TS 5.8.3 here; ensure it’s within Angular 20.2.x supported versions to avoid ngc/CLI issues.
Also applies to: 19-19, 22-24
🌐 Web query:
What TypeScript versions are officially supported by Angular v20.2.x (framework and CLI)?
💡 Result:
Angular v20.2.x supports TypeScript >=5.9.0 and <6.0.0 (applies to the framework and CLI). [1][2]
Sources:
[1] Angular — Version compatibility (angular.dev).
[2] "What’s new in Angular 20.2?" — Ninja Squad blog.
Upgrade TypeScript to ≥5.9.0 for Angular 20.2.x
In examples/angular/auto-refetching/package.json devDependencies, bump "typescript" from ^5.8.3 to at least ^5.9.0 (Angular 20.2.x requires TS ≥5.9.0 <6.0.0).
🤖 Prompt for AI Agents
In examples/angular/auto-refetching/package.json around lines 12 to 15, the
devDependency "typescript" is still ^5.8.3 which is incompatible with Angular
20.2.x; update the "typescript" entry in devDependencies to at least "^5.9.0"
(ensure the range stays <6.0.0), save package.json and run the package manager
install to update lockfile/dependencies.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", | ||
| "@tanstack/angular-query-experimental": "^5.87.1", | ||
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.15.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@angular/build": "^20.0.0", | ||
| "@angular/cli": "^20.0.0", | ||
| "@angular/compiler-cli": "^20.0.0", | ||
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2 + TS 5.8 combo: please verify supported TypeScript range.
Core/framework is ^20.2.4 while the workspace uses TypeScript 5.8.3. That’s likely fine, but Angular’s supported TS matrix can be strict across minors.
🌐 Web query:
Which TypeScript versions are officially supported by Angular 20.2.x (framework and CLI)?
💡 Result:
Angular 20.2.x officially supports TypeScript >=5.9.0 and <6.0.0 (framework and CLI). (angular.dev)
Citations:
Upgrade TypeScript to ≥5.9.0 <6.0.0
Angular 20.2.x officially requires TS >=5.9.0 <6.0.0; devDependencies currently specify 5.8.3—bump to at least 5.9.0 (examples/angular/infinite-query-with-max-pages/package.json) (angular.dev)
🤖 Prompt for AI Agents
In examples/angular/infinite-query-with-max-pages/package.json around lines 12
to 25 the devDependency "typescript" is pinned to 5.8.3 which is incompatible
with Angular 20.2.x; update the "typescript" version to a value in the supported
range (>=5.9.0 <6.0.0), e.g., set it to "5.9.0" or a later 5.x patch (5.9.x),
and then run npm install (or pnpm/ yarn) and verify the example builds.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2.x with TS 5.8.3: verify supported range
Angular’s supported TypeScript ranges can be tight. Please confirm 20.2.x officially supports TS 5.8.3 used here.
🌐 Web query:
What TypeScript versions are officially supported by Angular 20.2.x (framework and CLI)?
💡 Result:
Angular 20.2.x (framework and CLI) officially supports TypeScript >= 5.9.0 and < 6.0.0. [1]
Sources
[1] Angular Version compatibility (Angular docs).
Upgrade TypeScript to ≥5.9.0 <6.0.0
Angular 20.2.x requires TypeScript versions ≥5.9.0 and <6.0.0; TS 5.8.3 is unsupported. Update your devDependencies (e.g. in examples/angular/pagination/package.json) to bump TypeScript accordingly.
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 12–15 the project lists
Angular 20.2.x but still uses an unsupported TypeScript (5.8.3); update the
devDependencies TypeScript entry to a version compatible with Angular 20
(>=5.9.0 <6.0.0) such as ^5.9.0, then run npm/yarn install to refresh the
lockfile; ensure the updated version satisfies the peer range and rebuild/test
the example.
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular build/CLI/compiler-cli bumps: confirm CLI↔TS compatibility
Ensure @angular/cli@^20.2.2 and compiler-cli@^20.2.4 are compatible with TypeScript 5.8.3 and your tsconfig settings.
🌐 Web query:
Is TypeScript 5.8 supported by @angular/cli 20.2 and @angular/compiler-cli 20.2?
💡 Result:
Short answer: No. Angular 20.2 requires TypeScript >= 5.9 (< 6.0); TypeScript 5.8 is supported by earlier 20.0/20.1 releases but not by 20.2. [1][2]
Sources:
- Angular version compatibility table (Angular docs). [1]
- Angular (next) version compatibility table / release notes. [2]
Upgrade TypeScript to ≥5.9 <6.0 for Angular 20.2 compatibility
Change "typescript": "5.8.3" to at least "^5.9.0" (<6.0.0) in examples/angular/pagination/package.json to satisfy @angular/cli@20.2.2 and @angular/compiler-cli@20.2.4 requirements. (angular.dev)
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 22 to 25, the
TypeScript version is pinned to "5.8.3" which is incompatible with
@angular/cli@20.2.2 and @angular/compiler-cli@20.2.4; update the TypeScript
dependency to a version >=5.9 and <6.0 (e.g. "^5.9.0") to satisfy Angular 20.2
compatibility and ensure the version range is reflected in package.json
dependencies or devDependencies accordingly.
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "~5.8.2" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
TS ~5.8.2: align with example or confirm range
This uses ~5.8.2 while the example uses 5.8.3. Optional: align to 5.8.3 for determinism, or keep ~ for patch drift—just be consistent across Angular samples.
- "typescript": "~5.8.2"
+ "typescript": "5.8.3"🌐 Web query:
Does Angular 20.2.x officially support TypeScript 5.8.x?
💡 Result:
Short answer: No — Angular 20.2.x requires TypeScript >=5.9 and does not officially support TypeScript 5.8.x. [1]
Source: Angular "Version compatibility" table. [1]
Upgrade TypeScript to >=5.9.0 for Angular 20.2.x compatibility
Angular 20.2.x requires TypeScript >=5.9.0 <6.0.0, so ~5.8.2 is unsupported. (angular.dev)
- "typescript": "~5.8.2"
+ "typescript": ">=5.9.0 <6.0.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@angular/build": "^20.2.2", | |
| "@angular/cli": "^20.2.2", | |
| "@angular/compiler-cli": "^20.2.4", | |
| "typescript": "~5.8.2" | |
| "@angular/build": "^20.2.2", | |
| "@angular/cli": "^20.2.2", | |
| "@angular/compiler-cli": "^20.2.4", | |
| "typescript": ">=5.9.0 <6.0.0" |
🤖 Prompt for AI Agents
integrations/angular-cli-20/package.json lines 24-27: the TypeScript version is
pinned to ~5.8.2 which is incompatible with Angular 20.2.x; update the
dependency to a TypeScript range that satisfies Angular's requirement (>=5.9.0
<6.0.0) — for example set "typescript" to "^5.9.0" (or "~5.9.0") in
package.json, then run your package manager (npm/yarn/pnpm) to reinstall and run
the project build/tests to verify compatibility.
package.json
Outdated
| "url": "https://github.com/TanStack/query.git" | ||
| }, | ||
| "packageManager": "pnpm@10.13.1", | ||
| "packageManager": "pnpm@10.15.1", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm CI/dev environments support pnpm 10.15.1
Make sure GitHub Actions, local dev docs, and any version managers (.nvmrc/.node-version/Volta) align with pnpm@10.15.1 and its Node.js requirements.
Run:
🏁 Script executed:
#!/bin/bash
# Where do we pin Node?
fd -a '(\.nvmrc|\.node-version|package\.json|README\.md)' -HI | xargs -I {} sh -c 'echo "---- {}"; sed -n "1,120p" "{}" | rg -n "node|engines|volta|pnpm" -n || true'
# CI: check Node / pnpm setup
fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" -n || true'Length of output: 29271
🏁 Script executed:
#!/bin/bash
echo ".nvmrc content:"
sed -n '1,20p' .nvmrc
echo "CI workflows search:"
rg -nE 'setup-node|node-version|pnpm' -n .github/workflowsLength of output: 109
🏁 Script executed:
#!/bin/bash
echo ".nvmrc:"
head -n 5 .nvmrc || echo "no .nvmrc"
echo "Find .node-version:"
test -f .node-version && head -n 5 .node-version || echo "no .node-version"
echo "List CI workflow files:"
find .github/workflows -type f -maxdepth 2 -print || echo "no workflows directory"
echo "Search workflows for Node/pnpm setup:"
rg -n 'setup-node|node-version|pnpm' .github/workflows || echo "no matches"Length of output: 740
Align Node.js version and pin in CI
- .nvmrc sets Node.js v24.4.1, but pnpm@10 only officially supports Node.js 18–22 (pnpm.io); adjust .nvmrc (or use
.npmrcuse-node-version) to a supported LTS. - Add
actions/setup-node@v3with the samenode-versionin.github/workflows/ci.ymlandpr.yml. - Document the Node.js requirement in README (or add a
.node-version/Volta config) for local-dev consistency.
🤖 Prompt for AI Agents
In package.json around line 8 (the pnpm@10.15.1 pin) the project Node version in
.nvmrc (v24.4.1) is incompatible with pnpm@10 which officially supports Node
18–22; update .nvmrc to a supported LTS (for example 22.x) or upgrade/downgrade
the pinned pnpm to a version that supports Node 24, then add
actions/setup-node@v3 to .github/workflows/ci.yml and .github/workflows/pr.yml
with the same node-version value to enforce the runtime in CI, and document the
chosen Node requirement in README or add a .node-version / Volta config file for
local-dev consistency.
package.json
Outdated
| "@vitest/coverage-istanbul": "3.2.4", | ||
| "@vitest/eslint-plugin": "^1.3.9", | ||
| "cpy-cli": "^5.0.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Vitest upgrades: double-check coverage + eslint integration
After bumping vitest and @vitest/coverage-istanbul, confirm coverage provider config matches (istanbul vs v8) and lint rules still detect test globals.
Run:
Also applies to: 78-79
🏁 Script executed:
#!/bin/bash
# Look for coverage provider setting
fd -a 'vitest.config.*' -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "coverage|provider" "{}" -n || true'
# Ensure ESLint knows vitest env
fd -a '.eslintrc*' -HI | xargs -I {} sh -c 'echo "---- {}"; rg -n "vitest|jest" "{}" -n || true'Length of output: 1894
Add Vitest configuration for Istanbul coverage and enable Vitest in ESLint
- No
vitest.config.*detected → Vitest will use its default (V8) provider. Create a root config (e.g.vitest.config.ts) with:import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })
- None of the existing
.eslintrc.*files declare the Vitest plugin or environment → add to your ESLint config:so test globals are recognized.extends: ['plugin:vitest/recommended'], env: { vitest: true }
🤖 Prompt for AI Agents
In package.json around lines 49 to 51, there is no Vitest project config and
ESLint is not set up for Vitest; add a root vitest.config.* (e.g.,
vitest.config.ts) that calls defineConfig and sets test.coverage.provider to
"istanbul" so the @vitest/coverage-istanbul package is used, and update your
root ESLint configuration file(s) (.eslintrc.js/.json/.ts) to extend
"plugin:vitest/recommended" and add env: { vitest: true } so Vitest globals are
recognized by the linter.
| "@tanstack/vue-query": "workspace:*", | ||
| "@vitejs/plugin-vue": "^5.2.4", | ||
| "eslint-plugin-vue": "^9.27.0", | ||
| "eslint-plugin-vue": "^9.33.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm eslint-plugin-vue 9.33.0 rule changes don’t break linting.
New rules/defaults can flip errors. Please run the package lint to verify no new violations.
🏁 Script executed:
#!/bin/bash
pnpm -w -F @tanstack/vue-query-devtools run test:eslintLength of output: 484
🏁 Script executed:
#!/bin/bash
set -eux
# Install workspace dependencies first
pnpm install --frozen-lockfile
# Rerun eslint for the vue-query-devtools package
pnpm -w -F @tanstack/vue-query-devtools run test:eslintLength of output: 124908
Remove unused @ts-expect-error in vue-query’s ESLint config
In packages/vue-query/eslint.config.js (line 3), the @ts-expect-error is no longer needed and triggers TS2578. Delete or update that directive to fix the compile error, then rerun pnpm -w -F @tanstack/vue-query-devtools run test:eslint to confirm eslint-plugin-vue 9.33.0 rules don’t introduce new lint violations.
🤖 Prompt for AI Agents
In packages/vue-query/eslint.config.js around line 3, the inline
@ts-expect-error directive is no longer necessary and causes TS2578; remove that
@ts-expect-error comment (or replace it with a targeted ts-ignore/explicit
typing if genuinely required) so the file compiles cleanly, then run pnpm -w -F
@tanstack/vue-query-devtools run test:eslint to verify eslint-plugin-vue 9.33.0
doesn’t introduce new lint errors.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
b611e96 to
c307bb6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
packages/vue-query-devtools/package.json (1)
58-61: eslint-plugin-vue 9.33.0 + Vite 6.3.6 — rerun lint/build to catch rule flips.Please rerun the package’s ESLint and build to ensure no new violations or bundling regressions. This echoes an earlier comment about eslint-plugin-vue upgrades across the repo.
Suggested commands:
#!/bin/bash pnpm install --frozen-lockfile pnpm -w -F @tanstack/vue-query-devtools run test:eslint pnpm -w -F @tanstack/vue-query-devtools run buildpackage.json (2)
8-8: pnpm 10.15.1 — ensure Node version alignment in local/CI.Verify the repo’s pinned Node version(s) (.nvmrc/.node-version/Volta) and CI workflows match a Node release supported by pnpm 10. If mismatched, bump Node in those places or adjust pnpm. Mirrors a prior note on this topic.
Script to surface versions:
#!/bin/bash set -euo pipefail echo "Node pins:" fd -HI '(\.nvmrc|\.node-version|package\.json)' | xargs -I {} sh -c 'echo "---- {}"; rg -n "engines|volta|node" "{}" -n || true' echo echo "Workflows Node/pnpm setup:" fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" -n || true'
49-51: Ensure Istanbul coverage is configured for @vitest/coverage-istanbul.If no vitest.config.* sets coverage.provider, Vitest defaults to v8. Add a root config to opt into Istanbul and enable ESLint’s Vitest rules. (Reiterating an earlier suggestion.)
Add files:
// vitest.config.ts import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })- "devDependencies": { + "devDependencies": { "@vitest/eslint-plugin": "^1.3.9", ... "vitest": "3.2.4" }, + "eslintConfig": { + "extends": ["plugin:vitest/recommended"], + "env": { "vitest/globals": true } + }Also applies to: 77-79
🧹 Nitpick comments (2)
integrations/react-vite/package.json (1)
11-15: Vite 6.3.6 + @vitejs/plugin-react 4.7.0 upgrade — looks fine; consider moving to devDependencies.Tooling like Vite and its plugins are typically dev-only to avoid inflating consumers’ installs. If this package isn’t published with a runtime need for them, consider relocating to devDependencies.
Proposed change:
{ "dependencies": { "@tanstack/react-query": "workspace:*", "@tanstack/react-query-devtools": "workspace:*", - "@vitejs/plugin-react": "^4.7.0", - "react": "^19.0.0", - "react-dom": "^19.0.0", - "vite": "^6.3.6" + "react": "^19.0.0", + "react-dom": "^19.0.0" }, + "devDependencies": { + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.6" + } }package.json (1)
1-10: Optional: declare engines to codify supported Node/pnpm.Codifies runtime expectations and helps tooling.
{ "name": "root", "private": true, + "engines": { + "node": ">=18 <25", + "pnpm": ">=10.15.0" + }, "repository": {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/query-sync-storage-persister/package.json
- examples/vue/2.7-basic/package.json
- packages/query-core/package.json
- examples/solid/simple/package.json
- examples/vue/dependent-queries/package.json
🚧 Files skipped from review as they are similar to previous changes (72)
- integrations/react-next-15/package.json
- examples/solid/basic/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/basic/package.json
- examples/react/suspense/package.json
- integrations/svelte-vite/package.json
- packages/svelte-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/star-wars/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/simple/package.json
- packages/solid-query-devtools/package.json
- examples/angular/rxjs/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/playground/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/vue/simple/package.json
- examples/solid/astro/package.json
- packages/eslint-plugin-query/package.json
- .github/workflows/ci.yml
- examples/solid/basic-graphql-request/package.json
- examples/react/devtools-panel/package.json
- examples/react/react-router/package.json
- packages/react-query/package.json
- integrations/react-webpack-5/package.json
- packages/query-test-utils/package.json
- integrations/react-webpack-4/package.json
- examples/react/basic-graphql-request/package.json
- .github/workflows/autofix.yml
- examples/react/shadow-dom/package.json
- packages/svelte-query/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/persister/package.json
- examples/vue/nuxt3/package.json
- examples/angular/pagination/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/default-query-function/package.json
- packages/solid-query/package.json
- packages/react-query-persist-client/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/default-query-function/package.json
- integrations/solid-vite/package.json
- examples/angular/basic/package.json
- examples/vue/basic/package.json
- packages/vue-query/package.json
- examples/react/playground/package.json
- examples/svelte/simple/package.json
- packages/query-persist-client-core/package.json
- examples/angular/router/package.json
- examples/react/star-wars/package.json
- examples/react/chat/package.json
- packages/angular-query-experimental/package.json
- integrations/vue-vite/package.json
- examples/svelte/ssr/package.json
- examples/svelte/optimistic-updates/package.json
- .github/workflows/pr.yml
- examples/react/react-native/package.json
- examples/react/rick-morty/package.json
- examples/svelte/auto-refetching/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/basic-persister/package.json
- examples/svelte/basic/package.json
- examples/react/algolia/package.json
- examples/angular/auto-refetching/package.json
- examples/angular/devtools-panel/package.json
- examples/react/simple/package.json
- packages/query-devtools/package.json
- packages/angular-query-devtools-experimental/package.json
- integrations/angular-cli-20/package.json
- packages/react-query-devtools/package.json
- examples/angular/optimistic-updates/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.jsonpackages/vue-query-devtools/package.jsonintegrations/react-vite/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (3)
examples/react/offline/package.json (1)
16-25: MSW 2.11.1 and react-hot-toast 2.6.0 — quick smoke test the example.
- MSW: confirm the worker still registers with the existing "msw.workerDirectory": ["public"] config.
- react-hot-toast: verify toasts render under React 19 with no act warnings.
Commands to validate locally:
#!/bin/bash pnpm -F @tanstack/query-example-react-offline install --frozen-lockfile pnpm -F @tanstack/query-example-react-offline run dev # In the browser console: ensure MSW starts (no 404 for /mockServiceWorker.js) and UI toasts display.packages/solid-query-persist-client/package.json (1)
73-77: Dev dependency bumps align with peer ranges — LGTM.solid-js dev bump to ^1.9.9 is compatible with peer "^1.6.0"; vite-plugin-solid and npm-run-all2 minors are safe. No action needed.
package.json (1)
41-79: ESLint 9.35 + React Hooks plugin rc + Vitest 3.2 — re-run repo lint/tests.Major/minor linter/test bumps can surface new errors. Please run the affected scripts repo-wide.
#!/bin/bash pnpm install --frozen-lockfile pnpm run test:eslint pnpm run test:lib pnpm run test:types pnpm run test:build
| "@sveltejs/adapter-auto": "^6.1.0", | ||
| "@sveltejs/kit": "^2.37.1", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "svelte": "^5.36.8", | ||
| "svelte-check": "^4.3.0", | ||
| "svelte": "^5.38.7", | ||
| "svelte-check": "^4.3.1", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| "vite": "^6.3.6" | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
SvelteKit 2.37.1 + Svelte 5.38.7 — run svelte-check and build.
Minor/patch bumps should be safe; please validate types and a production build.
🏁 Script executed:
#!/bin/bash
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll install --frozen-lockfile
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll exec svelte-check
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll run buildLength of output: 3975
Fix SvelteKit setup and missing @tanstack/svelte-query dependency
svelte-check errored: cannot find ./.svelte-kit/tsconfig.json (you need to generate it before running type checks—e.g. run pnpm run dev or add a prepare: svelte-kit sync script).
vite build failed: cannot resolve package entry for @tanstack/svelte-query—you must install it (e.g. add "@tanstack/svelte-query" to your dependencies in examples/svelte/load-more-infinite-scroll/package.json) and verify its exports field.
🤖 Prompt for AI Agents
In examples/svelte/load-more-infinite-scroll/package.json around lines 15 to 22,
the project is missing a prepare script to generate .svelte-kit/tsconfig.json
and the @tanstack/svelte-query dependency required by the app; add a "prepare"
script that runs svelte-kit sync (so the tsconfig is generated for type checks)
and add "@tanstack/svelte-query" to the dependencies with a compatible version,
then run the package manager to install and confirm the package resolves (or pin
a version known to export correctly), and finally run the dev build to ensure
.svelte-kit is created and vite can resolve the new dependency.
c307bb6 to
2aa5b29
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
examples/angular/optimistic-updates/package.json (1)
12-16: Blocking: Angular 20.3.x requires TypeScript ≥5.9 — pinned 5.8.3 will fail ng build/check.Per Angular’s official compatibility table, v20.2.x and newer require TypeScript >=5.9.0 <6.0.0. Current pin is 5.8.3. Please bump. (angular.dev)
Apply:
"devDependencies": { "@angular/build": "^20.3.1", "@angular/cli": "^20.3.1", - "@angular/compiler-cli": "^20.3.0", - "typescript": "5.8.3" + "@angular/compiler-cli": "^20.3.0", + "typescript": "5.9.2" }Note: 5.9.2 is the current stable 5.9 patch. (github.com)
#!/bin/bash # Find Angular v20 examples still on TS <5.9 fd -a package.json examples/angular | while read -r f; do if rg -nP '"@angular/(core|common|compiler)"\s*:\s*"\^20\.' "$f" >/dev/null; then ts=$(jq -r '.devDependencies.typescript // empty' "$f") if [[ -n "$ts" && ! "$ts" =~ ^5\.9\. ]]; then echo "$f: typescript=$ts" fi fi done # Quick sanity: ensure ng builds won’t pick unsupported Node versions in CI (optional manual check).Also applies to: 23-26
🧹 Nitpick comments (2)
examples/angular/optimistic-updates/package.json (1)
23-25: Optional: align Angular toolchain patch versions for consistency.Consider bumping
@angular/compiler-clito^20.3.1to match@angular/buildand@angular/cli. Not required, but keeps the toolchain in lockstep.- "@angular/compiler-cli": "^20.3.0", + "@angular/compiler-cli": "^20.3.1",integrations/react-vite/package.json (1)
8-15: Move @vitejs/plugin-react and vite to devDependencies.Build-time tools; verified compatibility (plugin-react peer supports vite ^6.x; Vite requires Node >=18/20/22 and repo .nvmrc = 24.4.1).
File: integrations/react-vite/package.json
"dependencies": { "@tanstack/react-query": "workspace:*", "@tanstack/react-query-devtools": "workspace:*", - "@vitejs/plugin-react": "^4.7.0", "react": "^19.0.0", "react-dom": "^19.0.0", - "vite": "^6.2.4" + }, + "devDependencies": { + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.2.4" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (80)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (75)
- examples/vue/persister/package.json
- examples/react/react-router/package.json
- examples/react/simple/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/auto-refetching/package.json
- packages/svelte-query/package.json
- examples/react/basic/package.json
- examples/react/suspense/package.json
- examples/angular/router/package.json
- examples/angular/basic/package.json
- packages/solid-query-devtools/package.json
- packages/svelte-query-persist-client/package.json
- examples/solid/default-query-function/package.json
- packages/query-test-utils/package.json
- packages/query-persist-client-core/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/devtools-panel/package.json
- examples/solid/solid-start-streaming/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/basic/package.json
- integrations/svelte-vite/package.json
- examples/vue/basic/package.json
- examples/react/offline/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/simple/package.json
- packages/vue-query/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/shadow-dom/package.json
- examples/solid/astro/package.json
- integrations/vue-vite/package.json
- packages/vue-query-devtools/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/vue/nuxt3/package.json
- examples/solid/simple/package.json
- examples/react/react-native/package.json
- examples/react/algolia/package.json
- packages/react-query-devtools/package.json
- examples/vue/dependent-queries/package.json
- examples/react/star-wars/package.json
- examples/svelte/simple/package.json
- .github/workflows/ci.yml
- examples/react/chat/package.json
- packages/query-core/package.json
- packages/angular-query-persist-client/package.json
- examples/solid/basic-graphql-request/package.json
- integrations/solid-vite/package.json
- examples/svelte/ssr/package.json
- examples/react/playground/package.json
- integrations/angular-cli-20/package.json
- integrations/react-next-15/package.json
- examples/svelte/star-wars/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/svelte-query-devtools/package.json
- integrations/react-webpack-5/package.json
- examples/react/eslint-legacy/package.json
- .github/workflows/autofix.yml
- examples/svelte/load-more-infinite-scroll/package.json
- examples/vue/simple/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/playground/package.json
- packages/eslint-plugin-query/package.json
- .github/workflows/pr.yml
- examples/react/devtools-panel/package.json
- packages/react-query/package.json
- packages/angular-query-experimental/package.json
- examples/angular/rxjs/package.json
- packages/react-query-persist-client/package.json
- packages/query-devtools/package.json
- examples/angular/basic-persister/package.json
- package.json
- examples/angular/pagination/package.json
- examples/solid/basic/package.json
- examples/react/rick-morty/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/react/basic-graphql-request/package.jsonintegrations/react-vite/package.jsonpackages/solid-query/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (5)
packages/solid-query/package.json (1)
74-78: Dev dep bumps LGTM — verified no incompatible Solid/vite-plugin-solid pins.
- Only @tanstack/query-devtools, @tanstack/solid-query, @tanstack/solid-query-devtools, and @tanstack/solid-query-persist-client reference Solid/vite-plugin-solid; they use dev solid-js ^1.9.9, peer solid-js ^1.6.0 (where present), and dev vite-plugin-solid ^2.11.8. No packages pin solid-js <1.6 or >=2.
examples/angular/optimistic-updates/package.json (1)
20-20: LGTM: zone.js bump.0.15.1 pin is fine for Angular 20 examples.
examples/react/basic-graphql-request/package.json (2)
13-14: graphql-request 7.2.0 ↔ graphql 16.11.0 are peer‑compatible.graphql-request@7.2.0 declares peerDependencies "graphql": "14 - 16", so ^16.11.0 satisfies it. (app.unpkg.com)
19-19: Confirm CI/dev Node version — Vite 6 requires Node ≥18Vite 6 requires Node 18/20/22+ while @vitejs/plugin-react@4.7.0 allows Node ≥16. Ensure CI/images and the example use Node ≥18; add "engines": { "node": ">=18" } to examples/react/basic-graphql-request/package.json.
Previous automated search returned no workflow/node-version hints — verify locally with:
rg -n --hidden -S -g '.github/workflows/**' -C2 'actions/setup-node|node-version|node-version-file' || true [ -f .nvmrc ] && echo "==> .nvmrc" && cat .nvmrc [ -f .node-version ] && echo "==> .node-version" && cat .node-version rg -n '"engines"\s*:' examples/react/basic-graphql-request/package.json || trueexamples/react/default-query-function/package.json (1)
17-17: No action required — Node engines already aligned (Vite 6 + @vitejs/plugin-react@4.7.0)Vite 6 requires Node 18/20/22+. (vite.dev)
@vitejs/plugin-react@4.7.0 declares engines "node": "^14.18.0 || >=16.0.0" (accepts Node 16+). (git.dasfad.com)
Repo .nvmrc = 24.4.1 and workflows use tanstack/config/.github/setup (TanStack Config requires Node v18.17+), so CI/dev already target Node ≥18 — no change needed. (tanstack.com)
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
30e9fb8 to
270b12a
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (3)
integrations/react-webpack-5/package.json (1)
14-18: Babel bumps look fine; add Node engine and enable JSX automatic runtime in webpack.
- Add "engines": { "node": ">=14.15.0" } (or your repo-wide minimum, e.g., ">=18") to match babel-loader 9.x and modern toolchain expectations.
- In integrations/react-webpack-5/webpack.config.js, pass { runtime: "automatic" } to @babel/preset-react so React 19 projects don’t rely on classic runtime semantics.
Apply at the package root (outside the changed lines):
{ "name": "react-webpack-5", "private": true, + "engines": { + "node": ">=14.15.0" + }, "scripts": { "build": "webpack --mode production" },Verify across the repo:
#!/bin/bash set -euo pipefail echo "== Check engines field ==" jq -r '[."name", (.engines.node // "(no engines.node)")]|@tsv' integrations/react-webpack-5/package.json echo -e "\n== Check preset-react runtime option in webpack config ==" fd -a -g 'webpack.config.*' integrations/react-webpack-5 | while read -r f; do echo "=== $f ===" rg -nP -C2 '@babel/preset-react' "$f" || true rg -nP -C1 'runtime\s*:\s*["'\'']automatic["'\'']' "$f" || echo "(missing runtime: automatic)" doneexamples/angular/pagination/package.json (1)
21-26: Upgrade TypeScript to ≥5.9 <6.0 for Angular 20.3.xSame compatibility constraint as other Angular examples in this PR.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/react/basic-graphql-request/package.json (1)
13-14: graphql-request ↔ graphql: peer range OK; example build fails — add missing dependency
- Registry: graphql-request@7.2.0 declares peerDependency "graphql": "14 - 16"; graphql@16.11.0 satisfies this.
- Build: pnpm -C examples/react/basic-graphql-request build fails with Rollup unable to resolve import "@tanstack/react-query" (from examples/react/basic-graphql-request/src/index.tsx). Add "@tanstack/react-query" to examples/react/basic-graphql-request/package.json (dependencies) or ensure it's hoisted/installed, then rebuild.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (80)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (6)
- packages/query-devtools/package.json
- examples/vue/simple/package.json
- examples/vue/dependent-queries/package.json
- examples/solid/astro/package.json
- packages/query-sync-storage-persister/package.json
- examples/svelte/auto-refetching/package.json
🚧 Files skipped from review as they are similar to previous changes (68)
- examples/svelte/optimistic-updates/package.json
- packages/vue-query/package.json
- examples/react/suspense/package.json
- packages/react-query-devtools/package.json
- examples/vue/nuxt3/package.json
- examples/vue/basic/package.json
- packages/query-persist-client-core/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/solid/basic/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/shadow-dom/package.json
- packages/react-query/package.json
- examples/react/playground/package.json
- examples/react/react-router/package.json
- examples/svelte/playground/package.json
- examples/solid/simple/package.json
- packages/vue-query-devtools/package.json
- examples/svelte/simple/package.json
- examples/solid/default-query-function/package.json
- examples/angular/devtools-panel/package.json
- examples/react/default-query-function/package.json
- examples/svelte/basic/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/angular/simple/package.json
- examples/react/basic/package.json
- integrations/react-next-15/package.json
- packages/eslint-plugin-query/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/auto-refetching/package.json
- examples/react/offline/package.json
- .github/workflows/ci.yml
- integrations/svelte-vite/package.json
- packages/solid-query/package.json
- packages/solid-query-persist-client/package.json
- packages/svelte-query/package.json
- examples/react/devtools-panel/package.json
- examples/react/simple/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/star-wars/package.json
- .github/workflows/autofix.yml
- examples/angular/basic-persister/package.json
- examples/react/rick-morty/package.json
- packages/query-async-storage-persister/package.json
- examples/react/eslint-legacy/package.json
- packages/angular-query-experimental/package.json
- integrations/vue-vite/package.json
- packages/solid-query-devtools/package.json
- examples/angular/rxjs/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/svelte/ssr/package.json
- examples/angular/basic/package.json
- packages/svelte-query-devtools/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-test-utils/package.json
- examples/vue/persister/package.json
- examples/react/star-wars/package.json
- integrations/react-webpack-4/package.json
- .github/workflows/pr.yml
- examples/angular/optimistic-updates/package.json
- packages/react-query-persist-client/package.json
- packages/query-core/package.json
- examples/react/algolia/package.json
- examples/react/react-native/package.json
- integrations/solid-vite/package.json
- integrations/angular-cli-20/package.json
- package.json
- integrations/react-vite/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/react/basic-graphql-request/package.jsonexamples/solid/basic-graphql-request/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (5)
integrations/react-webpack-5/package.json (1)
18-18: html-webpack-plugin patch bump is safe.Patch update to ^5.6.4 is low risk and aligns with webpack 5. LGTM.
examples/angular/router/package.json (1)
20-20: zone.js bump to 0.15.1 looks rightMatches Angular 20.3 expectations; no action needed.
examples/angular/pagination/package.json (1)
19-19: zone.js 0.15.1 bump LGTMConsistent with Angular 20.3; keep pinned.
examples/solid/basic-graphql-request/package.json (1)
20-20: Action: install dependencies and re-run build; add minimal Vite config if resolution still failsBuild failed: vite not found (node_modules missing), so I couldn't verify the suggested change.
- Run:
- pnpm -C examples/solid/basic-graphql-request install
- pnpm -C examples/solid/basic-graphql-request build
- If the build still cannot resolve @tanstack/solid-query, add examples/solid/basic-graphql-request/vite.config.ts with:
import { defineConfig } from 'vite' import solid from 'vite-plugin-solid' export default defineConfig({ plugins: [solid()], optimizeDeps: { include: ['@tanstack/solid-query', '@tanstack/solid-query-devtools'], }, resolve: { // ensure ESM/browser fields are considered conditions: ['module', 'browser', 'import', 'default'], }, })examples/react/basic-graphql-request/package.json (1)
19-19: @vitejs/plugin-react@^4.7.0 with Vite 6 — confirm Node engine & CI buildFile: examples/react/basic-graphql-request/package.json (line 19)
- Sandbox Node: v24.3.0 — satisfies Vite 6’s Node requirement (18, 20, 22+). (vite.dev)
- @vitejs/plugin-react added Vite 6 to its peerDependencies (since v4.3.4); v4.7.0 is a later release and should be compatible. (gitlab.donnees.incubateur.anct.gouv.fr)
- Cannot verify the build here: vite and nx were not found and node_modules is missing (build failed with ENOENT). Re-run the example build in CI (or run pnpm install first) with the CI Node version to confirm it bundles cleanly, e.g.:
pnpm install && pnpm -w -F @tanstack/query-example-react-basic-graphql-request run build
| "devDependencies": { | ||
| "@angular/build": "^20.0.0", | ||
| "@angular/cli": "^20.0.0", | ||
| "@angular/compiler-cli": "^20.0.0", | ||
| "@angular/build": "^20.3.1", | ||
| "@angular/cli": "^20.3.1", | ||
| "@angular/compiler-cli": "^20.3.0", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
🧩 Analysis chain
TypeScript 5.8.3 is incompatible with Angular 20.3.x—bump to ≥5.9 <6.0
Angular 20.3 requires TS >=5.9,<6.0. Update to avoid install/build failures.
Apply:
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"To confirm the official range, run this web query:
🌐 Web query:
What TypeScript versions are officially supported by Angular 20.3.x (framework and CLI)?
💡 Result:
Angular 20.3.x supports TypeScript >= 5.9.0 and < 6.0.0 (i.e. TypeScript 5.9.x). [1]
Source: Angular version compatibility. [1] https://angular.dev/reference/versions
Bump TypeScript to >=5.9 <6.0 in examples/angular/router/package.json
Angular 20.3.x requires TypeScript >=5.9 and <6.0 (angular.dev reference/versions); current "typescript": "5.8.3" will cause install/build failures.
File: examples/angular/router/package.json — lines 22–26
Apply:
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "devDependencies": { | |
| "@angular/build": "^20.0.0", | |
| "@angular/cli": "^20.0.0", | |
| "@angular/compiler-cli": "^20.0.0", | |
| "@angular/build": "^20.3.1", | |
| "@angular/cli": "^20.3.1", | |
| "@angular/compiler-cli": "^20.3.0", | |
| "typescript": "5.8.3" | |
| "devDependencies": { | |
| "@angular/build": "^20.3.1", | |
| "@angular/cli": "^20.3.1", | |
| "@angular/compiler-cli": "^20.3.0", | |
| "typescript": "^5.9.0" |
🤖 Prompt for AI Agents
In examples/angular/router/package.json around lines 22 to 26, the TypeScript
devDependency is pinned to "5.8.3" which is incompatible with Angular 20.3.x;
update the "typescript" entry to a version range that satisfies Angular (for
example "typescript": ">=5.9 <6.0") so installs/builds use a compatible
TypeScript; update the package.json entry accordingly and then run npm install
(or pnpm/install tool used in this repo) to refresh lockfiles.
| "@tailwindcss/vite": "^4.1.13", | ||
| "@vitejs/plugin-react": "^4.7.0", | ||
| "tailwindcss": "^4.1.13", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
🧩 Analysis chain
Tailwind v4 + Vite plugin bump: verify migration (no PostCSS plugin, no v3 directives) and enforce Node version.
Upgrading to tailwindcss 4.1.x and @tailwindcss/vite 4.1.x requires:
- Vite plugin added in vite.config (import from '@tailwindcss/vite' and included in plugins).
- No PostCSS Tailwind plugin or legacy @tailwind base/components/utilities directives (v4 uses @import "tailwindcss").
- Node >=18 (Vite 6 and Tailwind v4).
Run to verify and surface actionable diffs:
Recommend setting engines to prevent CI drift:
{
"name": "@tanstack/query-example-chat",
"private": true,
"type": "module",
+ "engines": {
+ "node": ">=18.18"
+ },
"scripts": {🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate this example dir
DIR="$(dirname "$(rg -n -l '"name"\s*:\s*"@tanstack/query-example-chat"' -g 'examples/**/package.json' | head -n1)")"
echo "Example dir: $DIR"
echo "1) Check vite.config for @tailwindcss/vite import and usage"
rg -nC2 "from '@tailwindcss/vite'|plugins\s*:.*tailwind\s*\(" "$DIR" -g 'vite.config.*' || {
echo "WARNING: vite.config is missing @tailwindcss/vite import or plugin usage."; }
echo "2) Ensure no PostCSS Tailwind plugin remnants"
if fd -a -g 'postcss.config.*' "$DIR" >/dev/null; then
rg -n "tailwindcss" "$DIR"/postcss.config.* && \
echo "WARNING: Remove Tailwind from postcss.config for v4."
fi
echo "3) Detect legacy @tailwind directives in CSS"
rg -n "@tailwind\s+(base|components|utilities)" "$DIR" -g '**/*.{css,pcss}' && \
echo "WARNING: Replace legacy @tailwind directives with: @import \"tailwindcss\";"
echo "4) Flag legacy tailwind.config files (typically not used in v4)"
fd -a -g 'tailwind.config.*' "$DIR" || true
echo "5) Check engines.node"
jq -r '.engines?.node // "MISSING"' "$DIR/package.json"Length of output: 691
Tailwind v4 + Vite plugin: plugin present; add Node engine constraint
- examples/react/chat/vite.config.ts imports/uses '@tailwindcss/vite'.
- No postcss.config found and no legacy @tailwind directives detected.
- examples/react/chat/package.json is missing "engines.node" — add Node >=18.18 to prevent CI drift.
{
"name": "@tanstack/query-example-chat",
"private": true,
"type": "module",
+ "engines": {
+ "node": ">=18.18"
+ },
"scripts": {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@tailwindcss/vite": "^4.1.13", | |
| "@vitejs/plugin-react": "^4.7.0", | |
| "tailwindcss": "^4.1.13", | |
| { | |
| "name": "@tanstack/query-example-chat", | |
| "private": true, | |
| "type": "module", | |
| "engines": { | |
| "node": ">=18.18" | |
| }, | |
| "scripts": {}, | |
| "devDependencies": { | |
| "@tailwindcss/vite": "^4.1.13", | |
| "@vitejs/plugin-react": "^4.7.0", | |
| "tailwindcss": "^4.1.13" | |
| } | |
| } |
🤖 Prompt for AI Agents
examples/react/chat/package.json lines 17-19: package.json is missing an
"engines.node" field which can cause CI/node-version drift; add an "engines"
object with "node": ">=18.18" (or ">=18.18.0") to enforce Node >=18.18 for this
example, e.g. add "engines": { "node": ">=18.18" } at top-level of package.json
and commit the change.
270b12a to
ac1cf2e
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (4)
packages/solid-query-persist-client/package.json (1)
78-81: Fix peer dependency: solid-js range is too old for the tooling stack.Peer currently "^1.6.0" while dev env uses Solid 1.9.9 and vite-plugin-solid 2.11.8 (peer requires solid-js ≥1.7.2). Update peer range to avoid consumer warnings and ensure compatibility.
Apply:
"peerDependencies": { "@tanstack/solid-query": "workspace:^", - "solid-js": "^1.6.0" + "solid-js": "^1.9.9" }examples/angular/optimistic-updates/package.json (1)
12-26: Blocking: Angular 20.3 requires TypeScript ≥5.9 — bump TypeScript in all affected example package.json files.These package.json files pin typescript 5.8.3 while @angular/core is ^20.3.0; update devDependency to >=5.9 <6 and apply across the listed examples.
Affected files:
- examples/angular/auto-refetching/package.json
- examples/angular/basic/package.json
- examples/angular/basic-persister/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/pagination/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/angular/router/package.json
- examples/angular/rxjs/package.json
- examples/angular/simple/package.json
Apply (example patch):
"devDependencies": { "@angular/build": "^20.3.1", "@angular/cli": "^20.3.1", "@angular/compiler-cli": "^20.3.0", - "typescript": "5.8.3" + "typescript": ">=5.9 <6" }package.json (2)
8-8: Align Node version with pnpm@10.16.1 support (CI + local).Previous runs flagged Node 24 vs pnpm 10 mismatch. Please confirm pnpm 10.16.1’s supported Node range and align .nvmrc/CI setup accordingly.
#!/bin/bash # Inspect Node/pnpm pins across repo fd -a '(\.nvmrc|\.node-version|package\.json|README\.md)' -HI \ | xargs -I {} sh -c 'echo "---- {}"; rg -n "node|engines|volta|pnpm" "{}" -n || true' echo "---- Workflows" fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" -n || true'Does pnpm 10.16.1 officially support Node.js v24? If not, what Node.js versions are supported?
49-50: Vitest 3.2 + coverage-istanbul: set provider and enable ESLint env.Without a vitest.config, coverage will default to v8, not Istanbul. Also ensure ESLint recognizes Vitest globals.
Add vitest config and ESLint setup:
// vitest.config.ts import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })// eslint config (flat): eslint.config.js import vitest from '@vitest/eslint-plugin' export default [ vitest.configs.recommended, { languageOptions: { globals: { ...vitest.environments.env.globals } } }, ]Also applies to: 78-78
🧹 Nitpick comments (1)
package.json (1)
41-79: Add TypeScript 5.8 alias for matrix consistency.You alias 5.0–5.7; consider adding 5.8 to keep the test matrix consistent with devDependency 5.8.3.
"typescript56": "npm:typescript@5.6", "typescript57": "npm:typescript@5.7", + "typescript58": "npm:typescript@5.8", "vite": "^6.3.5",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (80)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- integrations/react-webpack-5/package.json
- integrations/vue-vite/package.json
- integrations/solid-vite/package.json
- integrations/react-vite/package.json
🚧 Files skipped from review as they are similar to previous changes (67)
- packages/solid-query/package.json
- examples/react/chat/package.json
- examples/svelte/simple/package.json
- examples/vue/basic/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/basic/package.json
- examples/angular/auto-refetching/package.json
- packages/svelte-query/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/basic/package.json
- examples/react/shadow-dom/package.json
- packages/solid-query-devtools/package.json
- packages/vue-query/package.json
- examples/react/devtools-panel/package.json
- examples/react/react-router/package.json
- packages/svelte-query-persist-client/package.json
- examples/svelte/basic/package.json
- examples/solid/default-query-function/package.json
- examples/react/simple/package.json
- examples/react/eslint-legacy/package.json
- examples/react/offline/package.json
- examples/solid/basic/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-test-utils/package.json
- packages/query-async-storage-persister/package.json
- examples/solid/basic-graphql-request/package.json
- examples/vue/persister/package.json
- examples/angular/basic-persister/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/rxjs/package.json
- examples/angular/query-options-from-a-service/package.json
- .github/workflows/ci.yml
- examples/angular/simple/package.json
- examples/svelte/auto-refetching/package.json
- packages/react-query/package.json
- examples/solid/simple/package.json
- packages/svelte-query-devtools/package.json
- examples/react/suspense/package.json
- packages/query-core/package.json
- packages/react-query-devtools/package.json
- examples/svelte/star-wars/package.json
- .github/workflows/autofix.yml
- examples/angular/pagination/package.json
- packages/angular-query-persist-client/package.json
- examples/react/basic-graphql-request/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/react-query-next-experimental/package.json
- examples/vue/nuxt3/package.json
- examples/react/playground/package.json
- packages/react-query-persist-client/package.json
- examples/react/react-native/package.json
- integrations/svelte-vite/package.json
- packages/vue-query-devtools/package.json
- examples/solid/solid-start-streaming/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/algolia/package.json
- examples/angular/router/package.json
- examples/svelte/playground/package.json
- examples/react/default-query-function/package.json
- integrations/react-webpack-4/package.json
- integrations/angular-cli-20/package.json
- examples/react/star-wars/package.json
- .github/workflows/pr.yml
- examples/svelte/ssr/package.json
- examples/react/rick-morty/package.json
- packages/angular-query-experimental/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-persist-client-core/package.jsonexamples/solid/astro/package.jsonpackages/solid-query-persist-client/package.jsonintegrations/react-next-15/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (9)
packages/query-persist-client-core/package.json (1)
66-66: LGTM on npm-run-all2 bump.Patch update; no runtime impact expected.
examples/vue/simple/package.json (1)
16-16: Plugin-vue patch bump approved.No config changes required given prior fixes in this example.
integrations/react-next-15/package.json (1)
9-9: Temporal polyfill bump approved.No known breaking changes for usage with Next 15/React 19.
packages/solid-query-persist-client/package.json (1)
73-77: Dev tool bumps OK.solid-js/vite-plugin-solid versions align with the rest of the repo.
packages/query-devtools/package.json (1)
67-81: Solid ecosystem bumps aligned.Versions match Solid 1.9.9 and vite-plugin-solid 2.11.8; no action needed.
packages/eslint-plugin-query/package.json (1)
62-70: Ensure CI pins Node >=18.18 (Node 20+ recommended) for ESLint 9 + @typescript-eslint v8No Node version config found in .github/workflows (rg returned no matches); verify your GitHub Actions workflows use actions/setup-node or a node-version matrix and set Node >=18.18 (prefer 20+).
examples/solid/astro/package.json (1)
15-22: Astro/Solid/Tailwind bumps look fine — run local build (sanity check)Sandbox attempt failed: sh: 1: astro: not found; sh: 1: nx: not found. Run locally or in CI to confirm no plugin API shifts with Astro 5.5.x + Solid 1.9.9:
pnpm -w -F @tanstack/query-example-solid-astro run build
package.json (2)
53-55: ESLint 9 + eslint-plugin-react-hooks@6.0.0-rc1 — compatibility verified.Repository uses flat configs (multiple eslint.config.js in packages — e.g., packages/react-query/eslint.config.js) and imports the plugin (rules include react-hooks/react-compiler, exhaustive-deps, rules-of-hooks). pnpm-lock shows eslint@9.35.0 and eslint-plugin-react-hooks@6.0.0-rc.1; upstream recommends using 6.0.0-rc.1 (the accidental 6.0.0 was deprecated). No change required.
80-107: Ensure direct deps on @tanstack/query-core where imported (not just pnpm.overrides).
Repo scan returned NO_MATCHES (ripgrep skipped files), so I couldn't verify — ensure every package that imports @tanstack/query-core (e.g. packages/query-async-storage-persister) lists "@tanstack/query-core": "workspace:*" in its package.json instead of relying solely on pnpm.overrides.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
ac1cf2e to
efd2d1f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
examples/react/star-wars/package.json (1)
11-14: Migrate off deprecated @mui/styles before keeping this bump.@mui/styles remains legacy in MUI v6 and is undesirable alongside React 19; prefer sx/styled or
@emotion/*. Keep the dep only until usage is removed.Run to locate legacy APIs in this example before removing the dependency:
#!/bin/bash # Find legacy MUI JSS usage rg -nP --glob 'examples/react/star-wars/**' '\bmakeStyles\b|\bwithStyles\b|\bcreateStyles\b|\bStylesProvider\b'After migration, drop the package:
"@mui/material": "^6.5.0", - "@mui/styles": "^6.4.8",examples/angular/basic/package.json (1)
12-15: Pin Angular framework to 20.2.x — 20.3.0 for core isn’t on npm.Latest published for core/common/compiler/platform-browser is 20.2.4; using ^20.3.0 will fail resolution. Align to 20.2.4. (npmjs.com)
Apply:
- "@angular/common": "^20.3.0", - "@angular/compiler": "^20.3.0", - "@angular/core": "^20.3.0", - "@angular/platform-browser": "^20.3.0", + "@angular/common": "^20.2.4", + "@angular/compiler": "^20.2.4", + "@angular/core": "^20.2.4", + "@angular/platform-browser": "^20.2.4",
🧹 Nitpick comments (1)
examples/react/star-wars/package.json (1)
19-20: Remove unused "react-router" dependencyNo direct imports of "react-router" were found in examples/react/star-wars/src — all routing imports use "react-router-dom". Remove the redundant entry in examples/react/star-wars/package.json:
- "react-router": "^6.30.1", "react-router-dom": "^6.30.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (80)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- integrations/solid-vite/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/devtools-panel/package.json
- packages/query-core/package.json
🚧 Files skipped from review as they are similar to previous changes (72)
- integrations/svelte-vite/package.json
- examples/react/playground/package.json
- examples/vue/dependent-queries/package.json
- packages/query-async-storage-persister/package.json
- .github/workflows/autofix.yml
- examples/solid/default-query-function/package.json
- examples/react/basic-graphql-request/package.json
- packages/react-query/package.json
- examples/angular/rxjs/package.json
- packages/solid-query/package.json
- packages/query-test-utils/package.json
- examples/solid/solid-start-streaming/package.json
- .github/workflows/pr.yml
- packages/solid-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- examples/vue/basic/package.json
- examples/vue/simple/package.json
- examples/react/eslint-legacy/package.json
- integrations/react-webpack-5/package.json
- examples/react/simple/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/pagination/package.json
- examples/solid/basic/package.json
- integrations/react-vite/package.json
- examples/react/react-router/package.json
- integrations/vue-vite/package.json
- packages/query-sync-storage-persister/package.json
- examples/svelte/playground/package.json
- examples/svelte/basic/package.json
- packages/vue-query-devtools/package.json
- examples/react/devtools-panel/package.json
- examples/vue/persister/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/suspense/package.json
- examples/angular/basic-persister/package.json
- examples/svelte/optimistic-updates/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/simple/package.json
- packages/vue-query/package.json
- examples/solid/astro/package.json
- examples/react/default-query-function/package.json
- examples/react/shadow-dom/package.json
- examples/svelte/ssr/package.json
- examples/svelte/star-wars/package.json
- examples/react/offline/package.json
- packages/svelte-query-devtools/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/router/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/basic/package.json
- packages/react-query-persist-client/package.json
- examples/react/algolia/package.json
- integrations/react-next-15/package.json
- examples/svelte/auto-refetching/package.json
- integrations/angular-cli-20/package.json
- examples/react/rick-morty/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/simple/package.json
- .github/workflows/ci.yml
- examples/react/chat/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/simple/package.json
- integrations/react-webpack-4/package.json
- packages/query-devtools/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/vue/nuxt3/package.json
- packages/angular-query-experimental/package.json
- packages/svelte-query/package.json
- examples/react/react-native/package.json
- package.json
- examples/angular/auto-refetching/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-devtools/package.jsonpackages/react-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (4)
packages/react-query-devtools/package.json (1)
86-90: Vite plugin peer compatible; run tests locally
- @vitejs/plugin-react@^4.7.0 peer: vite '^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0' — workspace Vite is ^6.x (root: ^6.3.5; many packages: ^6.2.4/^6.3.5), so the plugin peer range is satisfied.
- Tests couldn't be executed: vitest not found and node_modules missing. Run locally/CI: pnpm install && pnpm -C packages/react-query-devtools test:lib to confirm build/tests.
examples/react/star-wars/package.json (1)
23-23: LGTM: @vitejs/plugin-react ^4.7.0 with Vite ^6.2.4.Version pairing looks fine. Proceed; just ensure
pnpm -w -r buildstays green across examples.packages/solid-query-devtools/package.json (1)
68-72: Dev‑deps bumps look fine — confirmed vite usage & npm-run-all2; verify Solid externalization.
- npm-run-all2 v5.0.2 provides the npm-run-all CLI, so test:types (uses
npm-run-all --serial ...) remains valid.vite-plugin-solidis used in packages/solid-query-devtools/vite.config.ts (importsvite-plugin-solidand plugins: [solid()]); do not remove.solid-jsis currently a devDependency and no tsup config was found (build usestsup --tsconfig tsconfig.prod.json). Ensuresolid-jsis declared as a peerDependency and that tsup (ortsup-preset-solid) is configured to treat peer deps as externals so Solid is not bundled.examples/angular/basic/package.json (1)
19-19: zone.js 0.15.1 looks good.0.15.1 is the current release and is compatible with Angular 20. (npmjs.com)
examples/angular/basic/package.json
Outdated
| "@angular/build": "^20.3.1", | ||
| "@angular/cli": "^20.3.1", | ||
| "@angular/compiler-cli": "^20.3.0", |
There was a problem hiding this comment.
Align CLI/build/compiler-cli to 20.2.x and bump TypeScript to 5.9.x.
Mixing 20.3.x tooling with 20.2.x framework can cause peer/range churn; 20.2.x exists for CLI/build/compiler-cli. Also, Angular 20.2.x requires TypeScript >=5.9 <6.0 (current 5.8.3 is incompatible). (npmjs.com)
Apply:
- "@angular/build": "^20.3.1",
- "@angular/cli": "^20.3.1",
- "@angular/compiler-cli": "^20.3.0",
+ "@angular/build": "^20.2.0",
+ "@angular/cli": "^20.2.2",
+ "@angular/compiler-cli": "^20.2.4",And update TypeScript (outside the selected lines):
{
"devDependencies": {
"typescript": "^5.9.2"
}
}Refs: TS 5.9 GA and latest 5.9.2 release. (devblogs.microsoft.com)
🤖 Prompt for AI Agents
In examples/angular/basic/package.json around lines 22 to 24, the Angular
tooling deps are pinned to 20.3.x while the project framework uses 20.2.x and
TypeScript is currently 5.8.3; update "@angular/build", "@angular/cli", and
"@angular/compiler-cli" to a 20.2.x patch (e.g., ^20.2.2) so all Angular tooling
aligns to 20.2, and bump devDependency "typescript" to "^5.9.2" (outside these
lines) to satisfy Angular 20.2's TypeScript >=5.9 <6.0 requirement. Ensure
package.json remains valid JSON and run install to confirm no peer-range
conflicts.
efd2d1f to
8248b57
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (6)
packages/vue-query-devtools/package.json (1)
58-58: eslint-plugin-vue bumped to ^9.33.0 — re-run lint and confirm parser/core compatibilityMinor releases can flip defaults or add new rules. Please re-run this package’s lint and ensure
eslint,vue-eslint-parser, and shared configs align.#!/bin/bash set -eux # Ensure lockfile-resolved versions pnpm install --frozen-lockfile # Lint this package pnpm -w -F @tanstack/vue-query-devtools run test:eslint # Sanity-check versions used pnpm -w exec eslint --version pnpm -w why eslint eslint-plugin-vue vue-eslint-parserexamples/angular/query-options-from-a-service/package.json (1)
12-16: Bump TypeScript to 5.9.x to satisfy Angular 20.2+ peer requirement.Angular ≥20.2 requires TypeScript >=5.9.0 <6.0.0; keeping 5.8.3 will cause peer/compile errors with the updated Angular 20.3.x deps. (angular.dev)
Apply:
- "typescript": "5.8.3" + "typescript": ">=5.9.0 <6.0.0"Optional: pin to a concrete 5.9.x if you prefer deterministic builds.
Also applies to: 20-20, 23-25
examples/react/offline/package.json (1)
1-4: Add engines.node >=18 to match Vite 6/@vitejs/plugin-react requirementsVite 6 and plugin-react 4.x require Node 18+; enforce via engines to prevent dev/CI drift.
{ "name": "@tanstack/query-example-react-offline", "private": true, "type": "module", + "engines": { + "node": ">=18.0.0" + },Verification (CI/workflows and legacy CJS configs):
#!/bin/bash set -euo pipefail rg -nP 'actions/setup-node' .github/workflows || echo "No setup-node found" rg -nP 'node-version:\s*' .github/workflows || echo "No explicit node-version found" fd -pa 'vite.config.cjs' || echo "OK: no legacy vite.config.cjs"examples/react/algolia/package.json (2)
1-4: Add engines.node >=18 to align with Vite 6Same rationale as other examples; enforce Node 18+ to avoid CI/local mismatch.
{ "name": "@tanstack/query-example-react-algolia", "private": true, "type": "module", + "engines": { + "node": ">=18.0.0" + },
19-20: React 19 runtime with React 18 type packages → fix types mismatchUsing @types/react@18 and @types/react-dom@18 with React 19 can cause incorrect/duplicate typings. Either remove the type packages (React 19 ships types) or bump them to 19.
Option A (recommended: remove, rely on built-in types):
"devDependencies": { "@tanstack/eslint-plugin-query": "^5.89.0", - "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.2.4" }Option B (if you prefer keeping separate types):
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.0", + "@types/react-dom": "^19.0.0",examples/vue/nuxt3/package.json (1)
13-14: Add engines.node for Nuxt 3.19.x (prevents CI using incompatible Node).Nuxt 3.19 tightened Node requirements. Add an engines field so examples don’t run under Node versions Nuxt no longer supports. Nuxt docs also recommend keeping package.json up to date; Nuxt 4 shows the tightened range and 3.19.2 is a patch on that train—verify and set accordingly.
Proposed change:
"devDependencies": { "nuxt": "^3.19.2" - } + }, + "engines": { + "node": "^20.19.0 || >=22.12.0" + } }To confirm the exact engines for 3.19.2 before committing, run:
#!/bin/bash set -euo pipefail curl -s https://registry.npmjs.org/nuxt | jq -r '.versions["3.19.2"].engines.node'Refs: Nuxt v3.19.2 release notes (context for the 3.19 line), and Nuxt’s package.json docs (scripts/structure). Nuxt 4’s package.json shows the tightened engines range. (github.com)
🧹 Nitpick comments (1)
examples/react/algolia/package.json (1)
11-11: Prefer a caret range for @algolia/client-search in the exampleChange examples/react/algolia/package.json (line 11) to allow patch upgrades:
- "@algolia/client-search": "5.37.0", + "@algolia/client-search": "^5.37.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (80)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/react/eslint-legacy/package.json
- packages/query-test-utils/package.json
🚧 Files skipped from review as they are similar to previous changes (69)
- examples/svelte/basic/package.json
- examples/react/simple/package.json
- examples/svelte/playground/package.json
- examples/vue/basic/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-persist-client-core/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/suspense/package.json
- examples/react/default-query-function/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/basic/package.json
- packages/solid-query-persist-client/package.json
- examples/react/devtools-panel/package.json
- packages/query-core/package.json
- integrations/react-vite/package.json
- examples/angular/basic/package.json
- examples/vue/dependent-queries/package.json
- packages/solid-query/package.json
- examples/react/playground/package.json
- .github/workflows/ci.yml
- examples/svelte/auto-refetching/package.json
- examples/solid/default-query-function/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/basic-persister/package.json
- examples/vue/simple/package.json
- examples/react/shadow-dom/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/react-query-persist-client/package.json
- examples/solid/simple/package.json
- examples/solid/basic/package.json
- integrations/svelte-vite/package.json
- packages/svelte-query-persist-client/package.json
- examples/solid/astro/package.json
- examples/react/chat/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/ssr/package.json
- packages/vue-query/package.json
- examples/angular/router/package.json
- packages/query-sync-storage-persister/package.json
- .github/workflows/pr.yml
- examples/angular/devtools-panel/package.json
- examples/react/react-router/package.json
- examples/vue/persister/package.json
- packages/eslint-plugin-query/package.json
- .github/workflows/autofix.yml
- integrations/angular-cli-20/package.json
- packages/react-query-devtools/package.json
- integrations/react-next-15/package.json
- packages/angular-query-persist-client/package.json
- packages/solid-query-devtools/package.json
- examples/react/react-native/package.json
- integrations/react-webpack-5/package.json
- examples/angular/rxjs/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/pagination/package.json
- packages/react-query-next-experimental/package.json
- examples/svelte/star-wars/package.json
- examples/react/basic-graphql-request/package.json
- packages/react-query/package.json
- integrations/solid-vite/package.json
- package.json
- examples/react/star-wars/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/simple/package.json
- examples/angular/simple/package.json
- packages/query-async-storage-persister/package.json
- packages/svelte-query/package.json
- examples/angular/auto-refetching/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/vue-query-devtools/package.jsonpackages/angular-query-experimental/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (11)
packages/angular-query-experimental/package.json (1)
92-99: LGTM: Angular devDeps aligned to 20.3.x.No source impact; change is consistent with repo-wide updates.
integrations/vue-vite/package.json (1)
13-13: Plugin bump LGTM — verification blocked: workspace deps/tools missing (tsup, nx, node_modules).Build attempt failed with "tsup: not found", "nx: not found", and "Local package.json exists, but node_modules missing". Install workspace dependencies and re-run the checks so @tanstack/vue-query is built first:
pnpm -w install pnpm -w -r --filter @tanstack/vue-query build pnpm -w -F vue-vite run build pnpm -w -F vue-vite exec vue-tsc --noEmitEnsure @tanstack/vue-query is built first so Vite can resolve its exports.
examples/react/offline/package.json (1)
16-16: LGTM: dependency bumps are safe and consistentmsw, react-hot-toast, and @vitejs/plugin-react updates look good here.
Also applies to: 19-19, 22-22
examples/react/algolia/package.json (1)
21-21: LGTM: @vitejs/plugin-react upgradeVersion aligns with Vite 6 across examples.
packages/query-devtools/package.json (4)
67-69: Dev deps patch/minor bumps look safe.No API changes expected from @kobalte/core, @solid-primitives/keyed, and @solid-primitives/resize-observer at these ranges.
75-75: npm-run-all2 patch bump LGTM.No behavior change expected.
77-77: Watch for breaking changes: solid-transition-group@0.3.0 (no changelog found)
v0.3.0 published Jan 29, 2025; no release notes/CHANGELOG located — run a quick smoke test of the Solid Devtools UI and review commits/PRs around that publish date; open an issue with maintainers if you find regressions.
76-76: solid-js ^1.9.9 is compatible with vite-plugin-solid ^2.11.8 — repo-wide Solid versions are inconsistentpackages/query-devtools change is fine; repo inventory shows these packages still depend on solid-js ^1.6.0 while using vite-plugin-solid ^2.11.8:
- packages/solid-query/package.json
- packages/solid-query-devtools/package.json
- packages/solid-query-persist-client/package.json
Align those to ^1.9.9 or confirm mixed-version intent.
examples/react/rick-morty/package.json (3)
11-12: Emotion bumps look good with MUI 6.Minor updates; compatible with MUI v6 and React 19.
19-20: React Router 6.30.1: OK, but sanity-check examples.Upgrade remains within v6; no breaking API expected for basic usage. Verify example routes still render. (reactrouter.com)
23-23: @vitejs/plugin-react@4.7.0 — peer range OK for Vite 6.2; verify workspace resolutionnpm view reports peerDependencies: vite: '^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0' (compatible with Vite 6.2). npm ls here returned an empty tree, so local install/resolution wasn't verifiable — confirm your package manager/workspace (pnpm/yarn PnP) resolves the plugin (examples/react/rick-morty/package.json line 23).
| "@mui/material": "^6.5.0", | ||
| "@mui/styles": "^6.4.8", |
There was a problem hiding this comment.
🧩 Analysis chain
Re-evaluate use of @mui/styles with React 19 (deprecated, not compatible).
@mui/styles is deprecated and documented as not compatible with React 18/StrictMode (and thus risky on React 19). Prefer @mui/system, @emotion/styled, and the sx prop; plan a migration off makeStyles/withStyles. (v5-0-6.mui.com)
Run to assess impact and locate usage:
🏁 Script executed:
#!/bin/bash
# Find legacy @mui/styles usage across examples
rg -nP --type=ts,tsx,js,jsx -C2 '(makeStyles|withStyles|withTheme|createStyles|@mui/styles)'Length of output: 37
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== package.json (examples/react/rick-morty) ==="
if [ -f "examples/react/rick-morty/package.json" ]; then
sed -n '1,200p' examples/react/rick-morty/package.json || true
else
echo "File not found: examples/react/rick-morty/package.json"
fi
echo
echo "=== Search for legacy MUI styles usage (makeStyles/withStyles/withTheme/createStyles/@mui/styles) ==="
if command -v rg >/dev/null 2>&1; then
rg -n -S -C2 '(makeStyles|withStyles|withTheme|createStyles|@mui/styles)' --hidden --glob '!node_modules/**' || true
else
grep -RIn --exclude-dir=node_modules -E '(makeStyles|withStyles|withTheme|createStyles|@mui/styles)' . || true
fi
echo
echo "=== Search specifically for imports from '@mui/styles' ==="
if command -v rg >/dev/null 2>&1; then
rg -n -S -C2 "from ['\"]@mui/styles['\"]|require\(['\"]@mui/styles['\"]\)" --hidden --glob '!node_modules/**' || true
else
grep -RIn --exclude-dir=node_modules -E "from ['\"]@mui/styles['\"]|require\(['\"]@mui/styles['\"]\)" . || true
fiLength of output: 1175
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== package.json (examples/react/rick-morty) ==="
if [ -f "examples/react/rick-morty/package.json" ]; then
sed -n '1,200p' examples/react/rick-morty/package.json || true
else
echo "File not found: examples/react/rick-morty/package.json"
fi
echo
echo "=== List files under examples/react/rick-morty ==="
if [ -d "examples/react/rick-morty" ]; then
find examples/react/rick-morty -maxdepth 5 -type f -print || true
else
echo "Directory not found: examples/react/rick-morty"
fi
echo
echo "=== ripgrep search (use -uu to avoid type filters) ==="
if command -v rg >/dev/null 2>&1; then
rg -n -S -uu -C2 '(makeStyles|withStyles|withTheme|createStyles|@mui/styles)' --hidden --glob '!node_modules/**' || true
else
echo "rg not found; will fall back to find+grep"
fi
echo
echo "=== Fallback find+grep across repo for legacy MUI patterns ==="
find . -type f \( -iname '*.ts' -o -iname '*.tsx' -o -iname '*.js' -o -iname '*.jsx' -o -iname '*.mjs' -o -iname '*.cjs' -o -iname '*.vue' \) -not -path '*/node_modules/*' -print0 \
| xargs -0 grep -nE --line-number '(makeStyles|withStyles|withTheme|createStyles|@mui/styles)' || true
echo
echo "=== Explicit search for imports from '@mui/styles' ==="
find . -type f \( -iname '*.ts' -o -iname '*.tsx' -o -iname '*.js' -o -iname '*.jsx' -o -iname '*.mjs' -o -iname '*.cjs' -o -iname '*.vue' \) -not -path '*/node_modules/*' -print0 \
| xargs -0 grep -nE "from ['\"]@mui/styles['\"]|require\(['\"]@mui/styles['\"]\)" || trueLength of output: 2841
Remove @mui/styles (deprecated) and migrate makeStyles → @mui/system / @emotion.styled / sx for React 19 compatibility.
package.json includes @mui/styles and imports of makeStyles were found in these example files — migrate and remove the dependency.
- examples/react/rick-morty/package.json (dependency: "@mui/styles": "^6.4.8")
- examples/react/rick-morty/src/Home.jsx
- examples/react/rick-morty/src/Layout.tsx
- examples/react/star-wars/src/Home.jsx
- examples/react/star-wars/src/Layout.tsx
Action: replace makeStyles/withStyles usage with @mui/system or @emotion/styled (or use the sx prop), update the example code accordingly, and remove @mui/styles from package.json.
🤖 Prompt for AI Agents
In examples/react/rick-morty/package.json around lines 13-14, the project still
depends on the deprecated "@mui/styles"; remove that dependency and update usage
of makeStyles/withStyles found in examples/react/rick-morty/src/Home.jsx,
examples/react/rick-morty/src/Layout.tsx, examples/react/star-wars/src/Home.jsx
and examples/react/star-wars/src/Layout.tsx. Replace makeStyles/withStyles
patterns by converting classes to MUI v6 idioms: use the sx prop for simple
styling, migrate complex style objects to @emotion/styled or @mui/system's
styled utility, update imports to remove any import from "@mui/styles", ensure
theme access uses the new hook (or styled) patterns, adjust component props to
accept className where needed, and then remove "@mui/styles" from package.json
and run the app/build to verify no remaining makeStyles/withStyles imports.
85cef28 to
e174002
Compare
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
e174002 to
7918ea5
Compare
Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
5.2.1->5.37.0^20.0.0->^20.3.1^20.0.0->^20.3.2^20.0.0->^20.3.2^20.0.0->^20.3.1^20.0.0->^20.3.1^20.0.0->^20.3.1^20.0.0->^20.3.1^20.0.0->^20.3.1^20.0.0->^20.3.1^20.0.0->^20.3.1^0.15.3->^0.18.2^5.0.7->^5.1.1^8.1.3->^8.2.8^7.26.0->^7.28.4^7.24.9->^7.28.4^7.26.0->^7.28.3^7.25.9->^7.27.1^11.13.5->^11.14.0^11.13.5->^11.14.1^10.0.5->^10.0.11^0.4.4->^0.5.1^0.13.4->^0.13.11^6.1.8->^6.5.0^6.1.8->^6.4.8^1.2.2->^1.5.2^2.0.26->^2.1.3^1.1.3->^1.2.0^2.4.0->^2.5.3^4.0.14->^4.1.13^5.76.0->^5.90.1^10.4.0->^10.4.1^16.1.0->^16.3.0^2.0.0->^2.0.1^5.0.4->^5.0.5^4.3.4->^4.7.0^5.2.1->^5.2.4^1.1.36->^1.3.12^6.6.3->^6.6.4^8.3.0->^8.4.1^7.0.0->^7.1.0^50.5.0->^50.8.0^6.0.0-rc.2->^6.0.0-rc1^3.11.0->^3.12.4^9.27.0->^9.33.0^1.2.1->^1.2.2^52.0.11->^52.0.47^17.0.3->^17.1.7^2.0.0->^2.2.3^16.9.0->^16.11.0^7.1.2->^7.2.0^5.6.3->^5.6.4^6.2.1->^6.2.2^5.63.1->^5.64.0^2.6.6->^2.11.3^5.0.0->^5.0.2^3.12.4->^3.19.2^2.5.2->^2.6.0^0.76.3->^0.81.4^2.20.2->^2.28.0^5.12.5->^5.14.5^3.16.2->^3.19.1^4.12.0->^4.14.1^4.1.0->^4.16.0^0.19.13->^0.21.1^6.25.1->^6.30.1^6.25.1->^6.30.1^8.0.0->^8.4.0~7.8.0->~7.8.2^1.9.7->^1.9.9^0.2.3->^0.3.0^5.39.3->^5.39.4^4.3.1->^4.3.2^3.4.7->^3.4.17^4.0.14->^4.1.13^2.3.0->^2.8.1^0.5.3->^0.5.84.2.3->4.5.4^2.11.6->^2.11.8~0.15.0->~0.15.10.15.0->0.15.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
algolia/algoliasearch-client-javascript (@algolia/client-search)
v5.37.0Compare Source
v5.36.0Compare Source
v5.35.0Compare Source
v5.34.1Compare Source
v5.34.0Compare Source
v5.33.0Compare Source
v5.32.0Compare Source
v5.31.0Compare Source
v5.30.0Compare Source
v5.29.0Compare Source
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.