Fix segmentation fault on too few detections#1
Open
DevonMorris wants to merge 1 commit intomasterfrom
Open
Conversation
DevonMorris
force-pushed
the
devon/fix-segfault
branch
from
1e838a6 to
2cdfb7a
Compare
DevonMorris
changed the title
DevonMorris
commented
Feb 27, 2023
Downstream of the circle detection, refinement and optimization assumed that 4 circles are successfully extracted from the pointcloud. We fix this by ensuring that there are exactly 4 detections and returning early if that condition is not met.
DevonMorris
force-pushed
the
devon/fix-segfault
branch
from
2cdfb7a to
63abace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream of the circle detection, refinement and optimization assumed that 4 circles are successfully extracted from the pointcloud. We fix this by ensuring that there are exactly 4 detections and returning early if that condition is not met.