Skip to content

Conversation

@ilouzl
Copy link
Contributor

@ilouzl ilouzl commented May 21, 2025

No description provided.

@ilouzl ilouzl requested a review from Copilot May 22, 2025 08:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds optional scaling for raw sensor data by introducing a scaled flag and propagation of sensitivity settings through parsing and input modes.

  • Expand raw_data_msg to accept scaled and sensitivity parameters and apply actual unit scaling.
  • Update TapInputMode and on_raw_data to support the scaled flag and forward sensitivity.
  • Add tests, update examples, README, and history to document and validate the new behavior.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tapsdk/parsers.py Extended raw_data_msg signature and logic to apply scaling based on sensitivity.
tapsdk/inputmodes.py Added scaled parameter and attribute to TapInputMode.
tapsdk/tap.py Propagate scaled and sensitivity from input mode to parser.
tests/test_parsers.py New test for scaled raw data parsing.
tests/test_inputmodes.py New test for verifying scaled flag in TapInputMode.
examples/basic.py Example updated to enable scaling mode.
Readme.md Documentation on the scaled option added.
History.md Updated known issues section (Windows backend note).
Comments suppressed due to low confidence (1)

tapsdk/tap.py:182

  • [nitpick] The variable name sens is ambiguous. Rename it to sensitivity for clarity.
            sens = [0, 0, 0]

@ilouzl ilouzl merged commit ca191c4 into develop May 22, 2025
9 checks passed
@ilouzl ilouzl deleted the 28-native-raw-sensor-data-scaling branch May 22, 2025 09:01
@ilouzl
Copy link
Contributor Author

ilouzl commented May 22, 2025

solved #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants