Skip to content

Conversation

@ilouzl
Copy link
Contributor

@ilouzl ilouzl commented May 21, 2025

Summary

  • plug standard Python logging into Tap SDK modules
  • replace print statements with logger calls
  • update example to use logging

Testing

  • pytest -q

@ilouzl ilouzl marked this pull request as ready for review May 21, 2025 21:07
@ilouzl ilouzl requested a review from Copilot May 21, 2025 21:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates Python’s standard logging across the Tap SDK modules and example script, replacing all print calls with appropriate logger calls and configuring the example to initialize logging.

  • Added module-level logger = logging.getLogger(__name__) in SDK files and removed direct print statements.
  • Converted all print-based messaging in the example (basic.py) to use logger.info and configured logging.basicConfig.
  • Removed reliance on bleak._logger in favor of standard logging.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tapsdk/tap.py Imported logging, set up logger, replaced prints with logs
tapsdk/inputmodes.py Added module logger, switched to logger.warning
examples/basic.py Configured root logger, replaced all prints with logger.info
Comments suppressed due to low confidence (1)

tapsdk/inputmodes.py:2

  • The imported InputType is not used in this module; consider removing it to avoid an unused import.
from .enumerations import InputType

@ilouzl ilouzl merged commit 26542ee into develop May 21, 2025
9 checks passed
@ilouzl ilouzl deleted the codex/implement-logging-with-python's-logging-module branch May 21, 2025 21:28
@ilouzl ilouzl mentioned this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants