create Dockerfile for running server in a container#13
Open
owenlejeune wants to merge 1 commit intoTappedOutReborn:mainfrom
Open
create Dockerfile for running server in a container#13owenlejeune wants to merge 1 commit intoTappedOutReborn:mainfrom
owenlejeune wants to merge 1 commit intoTappedOutReborn:mainfrom
Conversation
|
Thanks for the PR, but the ip in the config should NOT be set to 127.0.0.1. It should be set to the ip or domain used to contact the server. |
Author
|
the idea is that this will be running in a docker container. setting the IP to 127.0.0.1 and exposing port 4242 allows the user to use <ip_of_device_running_docker>:4242 as the server address |
moit86663-hue
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.