Skip to content

CLAP-450 QA 사항 반영 Tony.tsx 4차 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Minkyu0424 merged 4 commits into from
Feb 18, 2025
Merged

CLAP-450 QA 사항 반영 Tony.tsx 4차 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f546ae
:recycle: [refactor] Lighthouse 기반 접근성 수치 향상
seorang42 Feb 18, 2025
896a282
:bug: [fix] : 회원 정보 수정 중 오류 발생 시 로딩 모달 꺼지지 않는 오류 수정
seorang42 Feb 18, 2025
ecdf7e5
:bug: [fix] : 수정되지 않았던 색상값 수정
seorang42 Feb 18, 2025
7f8dd8d
:bug: [fix] : 작업 보드, 팀 작업 현황 페이지 벗어나도 검색 필터 남아있는 오류 수정
seorang42 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!doctype html>
<html lang="">
<html lang="ko">
<head>
<meta charset="UTF-8" />
<link
Expand All @@ -8,6 +8,10 @@
<meta
name="viewport"
content="width=device-width, initial-scale=1.0" />
<meta
name="description"
content="TaskFlow, 업무 관리의 혁신을 이끄는 스마트한 서비스" />

<title>TaskFlow - 스마트한 업무 관리</title>
</head>
<body>
Expand Down
5 changes: 0 additions & 5 deletions public/MainLogo.svg
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/api/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const { isLogined } = storeToRefs(memberStore)

export const patchEditInfo = async (formdata: FormData) => {
if (!isLogined) return
const response = await formDataAxiosInstance.patch('/api/members/info', formdata)
const response = await formDataAxiosInstance.patch('/api/members/inf', formdata)
return response.data
}

Expand Down
12 changes: 8 additions & 4 deletions src/assets/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ body {
@apply button-large bg-white text-disabled border-border-1 hover:bg-background-2;
}
.button-large-red {
@apply button-large bg-red-1 text-white border-red-1 hover:bg-[#D61E1E];
@apply button-large bg-red-1 text-white border-red-1 hover:bg-[#CF1B1B];
}
.button-large-primary {
@apply button-large bg-primary1 text-white border-primary1 hover:bg-[#6D6EF0];
@apply button-large bg-primary1 text-white border-primary1 hover:bg-primary3;
}

.button-medium {
@apply flex items-center justify-center rounded px-4 py-2 font-semibold gap-1 text-xs cursor-pointer shrink-0 h-full max-h-[34px];
}
.button-medium-primary {
@apply button-medium bg-primary1 text-white hover:bg-[#6869DE];
@apply button-medium bg-primary1 text-white hover:bg-primary3;
}
.button-medium-secondary {
@apply button-medium bg-white border border-primary1 text-primary1 hover:bg-primary2;
Expand All @@ -73,7 +73,7 @@ body {
@apply flex items-center gap-1 text-xs font-semibold;
}
.button-small-primary {
@apply text-primary1;
@apply text-primary3;
}
.button-small-default {
@apply text-disabled;
Expand Down Expand Up @@ -149,6 +149,10 @@ body {
@apply flex w-full h-10 items-center rounded p-4 bg-white border border-border-1 cursor-pointer;
}

.hidden-text {
@apply absolute text-transparent w-[1px] h-[1px] overflow-hidden top-0 left-0;
}

.modal-enter-active,
.modal-leave-active {
transition:
Expand Down
24 changes: 14 additions & 10 deletions src/components/common/EditInformation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<div class="flex gap-6">
<label
for="fileInput"
class="mt-3 text-xs text-primary1 font-semibold cursor-pointer hover:underline"
class="mt-3 text-xs text-primary3 font-semibold cursor-pointer hover:underline"
>변경</label
>
<label
Expand Down Expand Up @@ -286,12 +286,12 @@ const handleFileDelete = () => {
}

const handleSubmit = async () => {
modalHeader.value = '정보 수정 중 입니다...'
modalBody.value = '잠시만 기다려주세요'
modalType.value = 'loadingType'
isModalVisible.value = true

if (isInvalid.value == false && isFull.value == false) {
modalHeader.value = '정보 수정 중 입니다...'
modalBody.value = '잠시만 기다려주세요'
modalType.value = 'loadingType'
isModalVisible.value = true

const formData = new FormData()
const memberInfo = {
name: DOMPurify.sanitize(name.value),
Expand All @@ -310,10 +310,14 @@ const handleSubmit = async () => {
selectedFile.value = null
}

await patchEditInfo(formData)
isModalVisible.value = false
isSuccessModalVisible.value = true
await memberStore.updateMemberInfoWithToken()
try {
await patchEditInfo(formData)
isModalVisible.value = false
isSuccessModalVisible.value = true
await memberStore.updateMemberInfoWithToken()
} catch {
isModalVisible.value = false
}
}
}
</script>
18 changes: 18 additions & 0 deletions src/components/common/MainLogo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<template>
<svg
width="134"
height="48"
viewBox="0 0 134 48"
fill="none"
xmlns="http://www.w3.org/2000/svg">
<path
d="M0 10.7411C0 9.99958 0.601128 9.39844 1.34266 9.39844H106.741V42.9649H1.34266C0.601128 42.9649 0 42.3637 0 41.6222V10.7411Z"
fill="#6D6EF0" />
<path
d="M131.9 40.7961C132.589 41.6779 131.961 42.9655 130.842 42.9655H101.371C100.629 42.9655 100.028 42.3643 100.028 41.6229V3.9C100.028 2.62302 101.643 2.06711 102.429 3.07338L131.9 40.7961Z"
fill="#6D6EF0" />
<path
d="M9.46257 18.9313H5.75684V15.709H16.7129V18.9313H13.0072V38.2656H9.46257V18.9313ZM19.6891 15.709H24.4904L28.1639 38.2656H24.6193L23.9748 33.7865V33.8509H19.9469L19.3024 38.2656H16.0156L19.6891 15.709ZM23.5559 30.7897L21.977 19.6403H21.9125L20.3658 30.7897H23.5559ZM34.3974 38.5878C32.6786 38.5878 31.3789 38.1045 30.4981 37.1378C29.6174 36.1496 29.177 34.7425 29.177 32.9165V31.6275H32.5282V33.1742C32.5282 34.6351 33.1405 35.3655 34.3652 35.3655C34.9667 35.3655 35.4178 35.1936 35.7186 34.8499C36.0408 34.4847 36.2019 33.9046 36.2019 33.1098C36.2019 32.1646 35.9871 31.3375 35.5575 30.6286C35.1278 29.8982 34.3329 29.0281 33.1727 28.0184C31.7119 26.7295 30.6915 25.5694 30.1115 24.5383C29.5314 23.4856 29.2414 22.3041 29.2414 20.9937C29.2414 19.2106 29.6926 17.8357 30.5948 16.869C31.4971 15.8808 32.8075 15.3867 34.5263 15.3867C36.2234 15.3867 37.5016 15.8808 38.3609 16.869C39.2417 17.8357 39.6821 19.2321 39.6821 21.0581V21.9926H36.3308V20.8325C36.3308 20.0592 36.1804 19.5006 35.8797 19.1569C35.5789 18.7917 35.1385 18.6091 34.5585 18.6091C33.3768 18.6091 32.786 19.3288 32.786 20.7681C32.786 21.5844 33.0009 22.3471 33.4305 23.056C33.8818 23.7649 34.6874 24.6242 35.8475 25.6339C37.3298 26.9228 38.3502 28.0936 38.9087 29.1463C39.4673 30.1989 39.7465 31.4342 39.7465 32.852C39.7465 34.6995 39.2847 36.1173 38.3609 37.1055C37.4587 38.0937 36.1375 38.5878 34.3974 38.5878ZM41.7787 15.709H45.3233V25.215L49.8346 15.709H53.3792L49.1579 23.9905L53.4437 38.2656H49.7379L46.7411 28.2118L45.3233 31.0797V38.2656H41.7787V15.709ZM55.1213 15.709H64.4984V18.9313H58.6659V25.215H63.2417V28.4373H58.6659V38.2656H55.1213V15.709ZM66.1982 15.709H69.7428V35.0432H75.5754V38.2656H66.1982V15.709ZM82.2729 38.5878C80.5328 38.5878 79.2009 38.0937 78.2771 37.1055C77.3534 36.1173 76.8915 34.721 76.8915 32.9165V21.0581C76.8915 19.2536 77.3534 17.8572 78.2771 16.869C79.2009 15.8808 80.5328 15.3867 82.2729 15.3867C84.0129 15.3867 85.3449 15.8808 86.2686 16.869C87.1924 17.8572 87.6542 19.2536 87.6542 21.0581V32.9165C87.6542 34.721 87.1924 36.1173 86.2686 37.1055C85.3449 38.0937 84.0129 38.5878 82.2729 38.5878ZM82.2729 35.3655C83.4974 35.3655 84.1096 34.6243 84.1096 33.142V20.8325C84.1096 19.3502 83.4974 18.6091 82.2729 18.6091C81.0484 18.6091 80.4361 19.3502 80.4361 20.8325V33.142C80.4361 34.6243 81.0484 35.3655 82.2729 35.3655ZM89.2137 15.709H92.6294L94.2084 33.0453H94.2729L95.9485 15.709H99.8154L101.491 33.0453H101.555L103.134 15.709H106.196L103.908 38.2656H99.4931L97.8819 23.056H97.8175L96.2063 38.2656H91.5016L89.2137 15.709ZM107.17 34.8499H110.586V38.2656H107.17V34.8499Z"
fill="white" />
</svg>
</template>
2 changes: 1 addition & 1 deletion src/components/common/OrderIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
xmlns="http://www.w3.org/2000/svg">
<path
d="M11 9.83984H5.00003C4.90108 9.83977 4.80433 9.86905 4.72204 9.92398C4.63974 9.97892 4.57559 10.057 4.53772 10.1484C4.49984 10.2399 4.48994 10.3405 4.50926 10.4375C4.52859 10.5345 4.57627 10.6237 4.64628 10.6936L7.64628 13.6936C7.69271 13.7401 7.74786 13.777 7.80856 13.8021C7.86926 13.8273 7.93432 13.8402 8.00003 13.8402C8.06574 13.8402 8.1308 13.8273 8.1915 13.8021C8.2522 13.777 8.30734 13.7401 8.35378 13.6936L11.3538 10.6936C11.4238 10.6237 11.4715 10.5345 11.4908 10.4375C11.5101 10.3405 11.5002 10.2399 11.4623 10.1484C11.4245 10.057 11.3603 9.97892 11.278 9.92398C11.1957 9.86905 11.099 9.83977 11 9.83984Z"
:fill="isActive ? '#7879EB' : '#D4D4D8'" />
:fill="isActive ? '#6061DB' : '#D4D4D8'" />
<path
d="M4.50919 5.5629C4.48995 5.65991 4.4999 5.76045 4.5378 5.8518C4.57563 5.94317 4.6397 6.02127 4.72191 6.07623C4.80412 6.13118 4.90079 6.16053 4.99968 6.16055H10.9997C11.0986 6.16063 11.1954 6.13134 11.2777 6.07641C11.36 6.02147 11.4241 5.94336 11.462 5.85194C11.4999 5.76053 11.5098 5.65994 11.4904 5.5629C11.4711 5.46585 11.4234 5.37673 11.3534 5.3068L8.35343 2.3068C8.30699 2.26031 8.25185 2.22343 8.19115 2.19827C8.13045 2.17311 8.06538 2.16016 7.99968 2.16016C7.93397 2.16016 7.86891 2.17311 7.80821 2.19827C7.74751 2.22343 7.69236 2.26031 7.64593 2.3068L4.64593 5.3068C4.57602 5.37676 4.52844 5.46589 4.50919 5.5629Z"
fill="#D4D4D8" />
Expand Down
1 change: 1 addition & 0 deletions src/components/filters/FilterInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
:class="width === 'full' && 'grow'">
<span class="filter-title">{{ title }}</span>
<input
:aria-label="title"
@input="onValueChange"
class="w-full h-8 border-b border-border-1 outline-none text-xs px-2" />
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/components/lists/ListBarTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
:class="`${!width && 'grow'} ${justifyCenter && 'justify-center'}`">
{{ content }}
<button
class="relative"
type="button"
v-if="sortBy"
@click="$emit('toggleSortBy', sortBy)">
<OrderIcon
:is-active="isActive"
:class="isASC && 'rotate-180'" />
<span class="hidden-text">정렬</span>
</button>
</div>
</template>
Expand Down
4 changes: 2 additions & 2 deletions src/components/member-management/MemberManagementAddByCsv.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
@change="handleFileUpload" />
<label
for="file"
class="cursor-pointer flex items-center gap-1 text-xs font-semibold text-primary1">
class="cursor-pointer flex items-center gap-1 text-xs font-semibold text-primary3">
<CommonIcons
:name="plusIcon"
:style="{ fill: '#7879EB' }" />
:style="{ fill: '#6061DB' }" />
파일로 일괄 추가
</label>
<ModalView
Expand Down
2 changes: 1 addition & 1 deletion src/components/request-approve/ManagerDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
{{ option.nickname }}
</p>
</div>
<p class="text-primary1 text-xs font-semibold">잔여 작업 : {{ option.remainingTasks }}</p>
<p class="text-primary3 text-xs font-semibold">잔여 작업 : {{ option.remainingTasks }}</p>
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/components/request-task/RequestTaskFileInputAfter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
</div>
<label
for="file"
class="w-full h-8 flex items-center justify-center text-primary1 font-semibold gap-1 text-xs cursor-pointer shrink-0 hover:bg-background-2">
class="w-full h-8 flex items-center justify-center text-primary3 font-semibold gap-1 text-xs cursor-pointer shrink-0 hover:bg-background-2">
<CommonIcons
:name="plusIcon"
:style="{ fill: '#7879eb' }" />
:style="{ fill: '#6061DB' }" />
<p>파일 선택</p>
</label>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/statistics/PeriodButtons.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="text-xs font-semibold flex gap-2 text-disabled">
<span class="text-primary1">지난</span>
<span class="text-primary3">지난</span>
<div class="flex gap-2">
<button
type="button"
Expand Down
3 changes: 2 additions & 1 deletion src/components/task-board/TaskBoardFilterBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ import { getCategory, getLabels } from '@/api/common'
import { useMemberStore } from '@/stores/member'
import { storeToRefs } from 'pinia'

const { params } = useTaskBoardParamsStore()
const { params, $reset } = useTaskBoardParamsStore()
$reset()

const onArrayChange = <Value extends number | string>(array: Value[], value: Value) => {
return array.includes(value) ? array.filter(el => el !== value) : [...array, value]
Expand Down
2 changes: 1 addition & 1 deletion src/components/task-detail/TaskDetailHistoryInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
class="hover:bg-background-2 rounded p-1">
<CommonIcons
:name="sendIcon"
:style="{ fill: isSendable ? '#7879EB' : '#A1A1AA' }"
:style="{ fill: isSendable ? '#6D6EF0' : '#A1A1AA' }"
@click="sendMessage" />
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/task-detail/TaskDetailManagerDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
{{ option.nickname }}
</p>
</div>
<p class="text-primary1 text-xs">잔여 작업 : {{ option.remainingTasks }}</p>
<p class="text-primary3 text-xs font-semibold">잔여 작업 : {{ option.remainingTasks }}</p>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/task-management/CategoryLine.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<button
type="button"
@click="router.push(`/category-first/${main.mainCategoryId}`)"
class="text-primary1 hover:underline">
class="text-primary3 hover:underline">
수정
</button>
<button
Expand Down
2 changes: 1 addition & 1 deletion src/components/task-management/CategoryLineSub.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<button
type="button"
@click="router.push(`/category-second/${sub.subCategoryId}`)"
class="text-primary1 hover:underline">
class="text-primary3 hover:underline">
수정
</button>
<button
Expand Down
2 changes: 1 addition & 1 deletion src/components/task-management/LabelManagement.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<button
type="button"
@click="addNewLabel"
class="text-primary1 w-[21px]">
class="text-primary3 w-[21px]">
확인
</button>
<button
Expand Down
2 changes: 1 addition & 1 deletion src/components/task-management/LabelManagementLine.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<button
type="button"
@click="isEdit && editValue.labelId === label.labelId ? finishEdit() : startEdit(label)"
class="text-primary1 w-[21px] hover:underline">
class="text-primary3 w-[21px] hover:underline">
{{ isEdit && editValue.labelId === label.labelId ? '확인' : '수정' }}
</button>
<button
Expand Down
2 changes: 1 addition & 1 deletion src/components/team-board/CurrentTaskRatio.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
>검토 중 {{ teamSummary.inReviewing }}건</span
>
</div>
<span class="text-xs font-semibold text-primary1">총 {{ teamSummary.totalTasks }}건</span>
<span class="text-xs font-semibold text-primary3">총 {{ teamSummary.totalTasks }}건</span>
</div>
<div class="w-full h-[360px] items-center gap-4">
<PieChart
Expand Down
2 changes: 1 addition & 1 deletion src/components/team-board/TeamBoardCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
>검토 중 {{ info.inReviewingTaskCount }}건</span
>
</div>
<span class="text-xs font-semibold text-primary1">총 {{ info.totalTaskCount }}건</span>
<span class="text-xs font-semibold text-primary3">총 {{ info.totalTaskCount }}건</span>
</div>
<div
class="w-full h-[360px] rounded-lg bg-primary2 shadow-custom overflow-y-auto scrollbar-hide flex flex-col items-center p-6 gap-4">
Expand Down
3 changes: 2 additions & 1 deletion src/components/team-board/TeamBoardFilterBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ import { useMemberStore } from '@/stores/member'
import { storeToRefs } from 'pinia'
import { useTeamBoardParamsChange } from '@/hooks/useTeamBoardParamsChange'

const { params } = useTeamBoardParamsStore()
const { params, $reset } = useTeamBoardParamsStore()
$reset()

const onParamsChange = useTeamBoardParamsChange()

Expand Down
12 changes: 6 additions & 6 deletions src/components/top-bar/NotificationMessage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,31 +14,31 @@
class="flex flex-col text-xs gap-1"
v-if="type === 'COMMENT'">
<span>
<span class="font-semibold text-primary1">"{{ title }}"</span> 작업에 새로운 댓글이
<span class="font-semibold text-primary3">"{{ title }}"</span> 작업에 새로운 댓글이
추가되었습니다
</span>
<span class="font-semibold text-body line-clamp-2">"{{ message }}"</span>
</div>
<div
class="text-xs"
v-else-if="type === 'TASK_REQUESTED'">
<span class="font-semibold text-primary1">"{{ title }}"</span> 작업이 요청되었습니다
<span class="font-semibold text-primary3">"{{ title }}"</span> 작업이 요청되었습니다
</div>
<div
class="text-xs"
v-else-if="type === 'STATUS_SWITCHED'">
<span class="font-semibold text-primary1">"{{ title }}"</span> 작업이
<span class="font-semibold text-primary1">{{ message }}</span> 상태로 변경되었습니다
<span class="font-semibold text-primary3">"{{ title }}"</span> 작업이
<span class="font-semibold text-primary3">{{ message }}</span> 상태로 변경되었습니다
</div>
<div
class="text-xs"
v-else-if="type === 'PROCESSOR_ASSIGNED'">
<span class="font-semibold text-primary1">"{{ title }}"</span> 작업이 할당되었습니다
<span class="font-semibold text-primary3">"{{ title }}"</span> 작업이 할당되었습니다
</div>
<div
class="text-xs"
v-else-if="type === 'PROCESSOR_CHANGED'">
<span class="font-semibold text-primary1">"{{ title }}"</span> 작업이 재할당되었습니다
<span class="font-semibold text-primary3">"{{ title }}"</span> 작업이 재할당되었습니다
</div>
</div>
</template>
Expand Down
6 changes: 3 additions & 3 deletions src/components/top-bar/NotificationModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
@click="readAllNotifi"
class="flex items-center gap-1 p-1 rounded hover:bg-background-2">
<CommonIcons :name="smallCheckIcon" />
<p class="font-semibold text-primary1 text-xs">모두 읽음</p>
<p class="font-semibold text-primary3 text-xs">모두 읽음</p>
</button>
<button
type="button"
Expand Down Expand Up @@ -41,12 +41,12 @@
@infinite="loadMoreNotifications"
class="flex items-center justify-center">
<template v-slot:complete>
<span class="flex py-4 items-center justify-center text-xs text-primary1">
<span class="flex py-4 items-center justify-center text-xs text-primary3">
알림을 전부 확인했습니다
</span>
</template>
<template v-slot:error>
<span class="flex py-4 items-center justify-center text-xs text-primary1">
<span class="flex py-4 items-center justify-center text-xs text-primary3">
데이터를 불러오는 중 오류가 발생했습니다. 다시 시도해 주세요.
</span>
</template>
Expand Down
Loading