Skip to content

Fix crashes in using delay map #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurav9878 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crashes in using delay map #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/typewriter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export default class TypeWriter extends Component {

if (delayMap) {
delayMap.forEach(({ at, delay }) => {
if (at === visibleChars || (currentToken && currentToken.match(at)) ) {
if (at === visibleChars || (currentToken && currentToken?.match(at)) ) {
Copy link
Copy Markdown
Owner

@TaylorBriggs TaylorBriggs Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The currentToken && part should be making sure currentToken is truthy. I'm not sure what the existential operator is supposed to catch here.

timeout += delay;
}
});
Expand Down